From: Stephen Hemminger <stephen@networkplumber.org>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, mst@redhat.com,
Yongji Xie <xieyongji@bytedance.com>,
jasowangio@gmail.com, chenbox@nvidia.com,
david.marchand@redhat.com
Subject: Re: [PATCH v2 01/11] build: define __counted_by as empty on unsupported compilers
Date: Mon, 28 Sep 2026 16:42:05 -0700 [thread overview]
Message-ID: <20260928164205.103049f3@phoenix.local> (raw)
In-Reply-To: <20260928132913.1376278-2-eperezma@redhat.com>
On Mon, 28 Sep 2026 15:29:03 +0200
Eugenio Pérez <eperezma@redhat.com> wrote:
> __counted_by is a GCC 14 / Clang 18 extension used in imported kernel
> uapi headers. Older compilers reject it with an error. Define it as an
> empty function-like macro when the compiler does not support it.
>
> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
> ---
NAK
Missing Signed-Of-By and the right way to handle counted_by is to
introduce and a new macro in rte_common.h (aka __rte_counted_by).
There are lots of places in DPDK that could use it.
If the problem is in vhost, then get it from stddef.h
next prev parent reply other threads:[~2026-09-28 23:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 13:29 [PATCH v2 00/11] Add vduse live migration features Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 01/11] build: define __counted_by as empty on unsupported compilers Eugenio Pérez
2026-09-28 23:42 ` Stephen Hemminger [this message]
2026-09-29 7:26 ` Maxime Coquelin
2026-09-28 13:29 ` [PATCH v2 02/11] uapi: import VDUSE and VFIO header from v7.3-rc3 kernel Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 03/11] vhost: introduce ASID support Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 04/11] vhost: add VDUSE API version negotiation Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 05/11] vhost: add virtqueues groups support to VDUSE Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 06/11] vhost: add ASID support to VDUSE IOTLB operations Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 07/11] vhost: claim VDUSE support for API version 1 Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 08/11] vhost: add net status feature to VDUSE Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 09/11] vhost: Support VDUSE QUEUE_READY feature Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 10/11] vhost: Support vduse suspend feature Eugenio Pérez
2026-09-28 13:29 ` [PATCH v2 11/11] doc: add release notes for VDUSE live migration support Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928164205.103049f3@phoenix.local \
--to=stephen@networkplumber.org \
--cc=chenbox@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=eperezma@redhat.com \
--cc=jasowangio@gmail.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox