DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dimon Zhao <dimon.zhao@nebula-matrix.com>
To: dev@dpdk.org
Cc: Dimon Zhao <dimon.zhao@nebula-matrix.com>,
	stable@dpdk.org, Leon Yu <leon.yu@nebula-matrix.com>,
	Sam Chen <sam.chen@nebula-matrix.com>
Subject: [PATCH v1 1/1] net/nbl: fix incorrect MTU stored in rxmode
Date: Mon, 28 Sep 2026 19:49:00 -0700	[thread overview]
Message-ID: <20260929024901.125398-2-dimon.zhao@nebula-matrix.com> (raw)
In-Reply-To: <20260929024901.125398-1-dimon.zhao@nebula-matrix.com>

The ethdev layer already updates data->mtu on success, so the
assignment is unnecessary. Remove it.

Fixes: 75cdda36a4c5 ("net/nbl: support MTU update")
Cc: stable@dpdk.org

Signed-off-by: Dimon Zhao <dimon.zhao@nebula-matrix.com>
---
 drivers/net/nbl/nbl_dev/nbl_dev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/nbl/nbl_dev/nbl_dev.c b/drivers/net/nbl/nbl_dev/nbl_dev.c
index 320f26619f..bf9e2f4e69 100644
--- a/drivers/net/nbl/nbl_dev/nbl_dev.c
+++ b/drivers/net/nbl/nbl_dev/nbl_dev.c
@@ -757,16 +757,13 @@ int nbl_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)
 	struct nbl_adapter *adapter = ETH_DEV_TO_NBL_DEV_PF_PRIV(eth_dev);
 	struct nbl_dev_mgt *dev_mgt = NBL_ADAPTER_TO_DEV_MGT(adapter);
 	struct nbl_dispatch_ops *disp_ops = NBL_DEV_MGT_TO_DISP_OPS(dev_mgt);
-	uint32_t frame_size = mtu + NBL_ETH_OVERHEAD;
 	int ret;
 
-	/* mtu setting is forbidden if port is start */
 	if (dev_data->dev_started) {
 		NBL_LOG(ERR, "port %d must be stopped before configuration", dev_data->port_id);
 		return -EBUSY;
 	}
 
-	dev_data->dev_conf.rxmode.mtu = frame_size;
 	ret = disp_ops->set_mtu(NBL_DEV_MGT_TO_DISP_PRIV(dev_mgt), dev_mgt->net_dev->vsi_id, mtu);
 	if (ret)
 		return ret;
-- 
2.34.1


      reply	other threads:[~2026-09-29  2:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  2:48 [PATCH v1 0/1] fix incorrect MTU stored in rxmode Dimon Zhao
2026-09-29  2:49 ` Dimon Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929024901.125398-2-dimon.zhao@nebula-matrix.com \
    --to=dimon.zhao@nebula-matrix.com \
    --cc=dev@dpdk.org \
    --cc=leon.yu@nebula-matrix.com \
    --cc=sam.chen@nebula-matrix.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox