DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Aleksandr Khromov <haa@amicon.ru>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Robin Jarry <rjarry@redhat.com>, <dev@dpdk.org>,
	<konstantin.ananyev@huawei.com>, <olivier.matz@6wind.com>,
	<sdl.dpdk@linuxtesting.org>, <stable@dpdk.org>, <rrv@amicon.ru>,
	<haa@amicon.ru>
Subject: Re: [PATCH] net: fix signed shift overflow in IPv6 phdr cksum
Date: Tue, 29 Sep 2026 10:21:53 +0300	[thread overview]
Message-ID: <20260929072153.56119-1-haa@amicon.ru> (raw)
In-Reply-To: <HTNMG94CQuKiMcKhE4so4g@monjalon.net>

On 28/09/2026 16:18, Thomas Monjalon wrote:
> Should we merge this patch and expect another one for the endian issue?

Yes, please apply it as is. The byte order problem is a separate,
pre-existing bug that only shows up on big-endian builds, so I would
rather fix it in its own commit.

I will send a follow-up series with two patches:
  - net: use rte_cpu_to_be_32() for the next header in the IPv6
    pseudo-header, as Stephen suggested;
  - net/hinic: same fix for the copy in hinic_ipv6_phdr_cksum().

Thanks Stephen for the review.

      reply	other threads:[~2026-09-29 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  7:47 [PATCH] net: fix signed shift overflow in IPv6 phdr cksum Aleksandr Khromov
2026-09-21 21:15 ` Stephen Hemminger
2026-09-28 14:18   ` Thomas Monjalon
2026-09-29  7:21     ` Aleksandr Khromov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929072153.56119-1-haa@amicon.ru \
    --to=haa@amicon.ru \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=olivier.matz@6wind.com \
    --cc=rjarry@redhat.com \
    --cc=rrv@amicon.ru \
    --cc=sdl.dpdk@linuxtesting.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox