DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: mst@redhat.com, david.marchand@redhat.com, dev@dpdk.org,
	Yongji Xie <xieyongji@bytedance.com>,
	chenbox@nvidia.com, Bruce Richardson <bruce.richardson@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	jasowangio@gmail.com
Subject: [PATCH v3 3/9] vhost: add VDUSE API version negotiation
Date: Tue, 29 Sep 2026 12:53:33 +0200	[thread overview]
Message-ID: <20260929105339.1554051-4-eperezma@redhat.com> (raw)
In-Reply-To: <20260929105339.1554051-1-eperezma@redhat.com>

From: Maxime Coquelin <maxime.coquelin@redhat.com>

As preliminary step to support new VDUSE API version
introducing ASID support, this patch adds API version
negotiation to keep compatibility with older kernels.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 lib/vhost/vduse.c | 14 ++++++++++++--
 lib/vhost/vhost.h |  1 +
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c
index 3c72bafcf511..ceef207ad2df 100644
--- a/lib/vhost/vduse.c
+++ b/lib/vhost/vduse.c
@@ -25,7 +25,7 @@
 #include "vhost.h"
 #include "virtio_net_ctrl.h"
 
-#define VHOST_VDUSE_API_VERSION 0
+#define VHOST_VDUSE_API_VERSION 0ULL
 #define VDUSE_CTRL_PATH "/dev/vduse/control"
 
 struct vduse {
@@ -680,7 +680,7 @@ vduse_device_create(const char *path, bool compliant_ol_flags, bool extbuf, bool
 	uint32_t i, max_queue_pairs, total_queues;
 	struct virtio_net *dev;
 	struct virtio_net_config vnet_config = {{ 0 }};
-	uint64_t ver = VHOST_VDUSE_API_VERSION;
+	uint64_t ver;
 	uint64_t features;
 	const char *name = path + strlen("/dev/vduse/");
 	bool reconnect = false;
@@ -700,6 +700,15 @@ vduse_device_create(const char *path, bool compliant_ol_flags, bool extbuf, bool
 		return -1;
 	}
 
+	if (ioctl(control_fd, VDUSE_GET_API_VERSION, &ver)) {
+		VHOST_CONFIG_LOG(name, ERR, "Failed to get API version: %s", strerror(errno));
+		ret = -1;
+		goto out_ctrl_close;
+	}
+
+	ver = RTE_MIN(ver, VHOST_VDUSE_API_VERSION);
+	VHOST_CONFIG_LOG(name, INFO, "Using VDUSE API version %" PRIu64 "", ver);
+
 	if (ioctl(control_fd, VDUSE_SET_API_VERSION, &ver)) {
 		VHOST_CONFIG_LOG(name, ERR, "Failed to set API version: %" PRIu64 ": %s",
 				ver, strerror(errno));
@@ -800,6 +809,7 @@ vduse_device_create(const char *path, bool compliant_ol_flags, bool extbuf, bool
 	strlcpy(dev->ifname, path, sizeof(dev->ifname));
 	dev->vduse_ctrl_fd = control_fd;
 	dev->vduse_dev_fd = dev_fd;
+	dev->vduse_api_ver = ver;
 
 	ret = vduse_reconnect_log_map(dev, !reconnect);
 	if (ret < 0)
diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index e0441adb6193..36d65bc2c162 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -532,6 +532,7 @@ struct __rte_cache_aligned virtio_net {
 	int			postcopy_listening;
 	int			vduse_ctrl_fd;
 	int			vduse_dev_fd;
+	uint64_t		vduse_api_ver;
 
 	struct vhost_virtqueue	*cvq;
 
-- 
2.55.0


  parent reply	other threads:[~2026-09-29 10:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 10:53 [PATCH v3 0/9] Add vduse live migration features Eugenio Pérez
2026-09-29 10:53 ` [PATCH v3 1/9] uapi: import VDUSE and VFIO header from v7.3-rc5 kernel Eugenio Pérez
2026-09-29 11:41   ` Maxime Coquelin
2026-09-29 14:38   ` David Marchand
2026-09-29 10:53 ` [PATCH v3 2/9] vhost: introduce ASID support Eugenio Pérez
2026-09-29 12:08   ` Maxime Coquelin
2026-09-29 10:53 ` Eugenio Pérez [this message]
2026-09-29 12:28   ` [PATCH v3 3/9] vhost: add VDUSE API version negotiation Maxime Coquelin
2026-09-29 10:53 ` [PATCH v3 4/9] vhost: add virtqueues groups support to VDUSE Eugenio Pérez
2026-09-29 12:42   ` Maxime Coquelin
2026-09-29 10:53 ` [PATCH v3 5/9] vhost: add ASID support to VDUSE IOTLB operations Eugenio Pérez
2026-09-29 12:56   ` Maxime Coquelin
2026-09-29 10:53 ` [PATCH v3 6/9] vhost: claim VDUSE support for API version 1 Eugenio Pérez
2026-09-29 13:12   ` Maxime Coquelin
2026-09-29 10:53 ` [PATCH v3 7/9] vhost: add net status feature to VDUSE Eugenio Pérez
2026-09-29 13:27   ` Maxime Coquelin
2026-09-29 10:53 ` [PATCH v3 8/9] vhost: Support VDUSE QUEUE_READY feature Eugenio Pérez
2026-09-29 14:25   ` Maxime Coquelin
2026-09-29 10:53 ` [PATCH v3 9/9] vhost: Support vduse suspend feature Eugenio Pérez
2026-09-29 12:13   ` Maxime Coquelin
2026-10-03  9:54 ` [PATCH v3 0/9] Add vduse live migration features David Marchand
2026-10-05  8:11   ` Maxime Coquelin
2026-10-05 10:09     ` Eugenio Perez Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929105339.1554051-4-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=chenbox@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jasowangio@gmail.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=stephen@networkplumber.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox