DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Khromenok <roma55592@yandex.ru>
Cc: dev@dpdk.org
Subject: Re: [PATCH 0/3] net/intel: make link state configurable on device start
Date: Sun, 4 Oct 2026 09:15:13 -0700	[thread overview]
Message-ID: <20261004091513.54a16319@phoenix.local> (raw)
In-Reply-To: <20261003215345.1774614-1-roma55592@yandex.ru>

On Sat,  3 Oct 2026 23:53:45 +0200
Roman Khromenok <roma55592@yandex.ru> wrote:

> On Sat, 3 Oct 2026, Stephen Hemminger wrote:
> > If you want something done better it must done at ethdev layer
> > and you must coordinate across all existing devices.  
> 
> Thanks, understood. I withdraw this series.
> 
> The problem behind it: a firewall starts its ports at boot but must keep
> the ports that are disabled in its configuration down, so that the link
> partner never sees them. Today rte_eth_dev_start() brings the link up
> on most drivers, and the application can only bring it down afterwards.
> 
> Would an RFC along these lines be acceptable?
> - ethdev keeps the administrative link state (RFC 2863 ifAdminStatus)
>   set by rte_eth_dev_set_link_down()/up(), including before the port
>   is started;
> - rte_eth_dev_start() honors it: drivers that support it keep the link
>   down on start, and for the others ethdev calls dev_set_link_down()
>   right after dev_start(), so the semantics are the same for all devices;
> - a new feature in the features matrix to track driver support.
> 
> Or would you prefer a separate API for the administrative state instead
> of changing the behavior of rte_eth_dev_set_link_down()?
> 
> Roman

No. Application should not call device start until it expects
to bring link up.

The RFC 2863 stuff is for layered devices where lower layers are
separate from the upper ones (ie. tunnels, bonding, etc).

  reply	other threads:[~2026-10-04 16:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 19:43 [PATCH 0/3] net/intel: make link state configurable on device start Roman Khromenok
2026-10-02 19:43 ` [PATCH 1/3] net/ice: " Roman Khromenok
2026-10-02 19:43 ` [PATCH 2/3] net/i40e: " Roman Khromenok
2026-10-02 19:43 ` [PATCH 3/3] net/ixgbe: " Roman Khromenok
2026-10-03 16:18 ` [PATCH 0/3] net/intel: " Stephen Hemminger
2026-10-03 21:53   ` Roman Khromenok
2026-10-04 16:15     ` Stephen Hemminger [this message]
2026-10-04 16:13 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261004091513.54a16319@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=roma55592@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox