From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA96CA5FFF for ; Wed, 7 Oct 2026 07:26:51 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8589942D55; Wed, 7 Oct 2026 09:25:06 +0200 (CEST) Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by mails.dpdk.org (Postfix) with ESMTP id BA3F941157 for ; Wed, 7 Oct 2026 09:24:49 +0200 (CEST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 9DA4220000E; Wed, 7 Oct 2026 09:24:49 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 69995200002; Wed, 7 Oct 2026 09:24:49 +0200 (CEST) Received: from lsv03583.swis.in-blr01.nxp.com (lsv03583.swis.in-blr01.nxp.com [92.120.146.12]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id EE72418000B1; Wed, 7 Oct 2026 15:24:48 +0800 (+08) From: Hemant Agrawal To: stephen@networkplumber.org, thomas@monjalon.net, dev@dpdk.org Subject: [PATCH v22 21/27] net/dpaa: support non fmX-macY type of shared Ethernet name Date: Wed, 7 Oct 2026 12:54:33 +0530 Message-Id: <20261007072439.3135351-22-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20261007072439.3135351-1-hemant.agrawal@nxp.com> References: <20261006092703.2138929-1-hemant.agrawal@nxp.com> <20261007072439.3135351-1-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When using a shared interface, the Linux interface name (as shown by ifconfig) may differ from the fmX-macY style name used by DPDK. Add a "drv_sh_if_name" device argument to let the application provide the kernel shared interface name to the DPAA PMD. e.g. -a dpaa_bus:fm1-mac3,drv_sh_if_name=eth1 Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa.rst | 4 ++ drivers/net/dpaa/dpaa_ethdev.c | 74 +++++++++++++++++++++++++++++++++- 2 files changed, 76 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/dpaa.rst b/doc/guides/nics/dpaa.rst index d03027d8bb..67191c83ae 100644 --- a/doc/guides/nics/dpaa.rst +++ b/doc/guides/nics/dpaa.rst @@ -289,6 +289,10 @@ the ``-a`` EAL option (e.g. ``-a dpaa_bus:fm1-mac3,drv_rx_taildrop=64``): ``drv_fmcless_rxq`` In FMCLESS mode, override the number of Rx frame queues to create. +``drv_sh_if_name`` + Provide the kernel Linux interface name for a shared MAC interface when it + differs from the ``fmX-macY`` style name used by DPDK. + FMAN Config ----------- diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index a367f4512f..859c1e946a 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -58,11 +58,15 @@ #define DRIVER_RX_TAILDROP "drv_rx_taildrop" #define DRIVER_TX_TAILDROP "drv_tx_taildrop" #define DRIVER_FMCLESS_RXQ "drv_fmcless_rxq" +#define DRIVER_SH_IF_NAME "drv_sh_if_name" #define RTE_PRIORITY_103 103 /* Maximum number of stale frame queues cleaned up per congestion group. */ #define DPAA_CGR_STALE_FQ_MAX 64 +static int dpaa_get_devargs_str(struct rte_devargs *devargs, const char *key, + char *val, size_t size); + /* Supported Rx offloads */ static uint64_t dev_rx_offloads_sup = RTE_ETH_RX_OFFLOAD_SCATTER; @@ -257,6 +261,7 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev) int speed, duplex; int ret, rx_status, socket_fd; struct ifreq ifr; + char sh_if_name[IFNAMSIZ]; PMD_INIT_FUNC_TRACE(); @@ -278,7 +283,24 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev) DPAA_PMD_ERR("Cannot open IF socket"); return -errno; } - strlcpy(ifr.ifr_name, dpaa_intf->name, IFNAMSIZ); + + sh_if_name[0] = '\0'; + ret = dpaa_get_devargs_str(dpaa_dev->device.devargs, + DRIVER_SH_IF_NAME, sh_if_name, + sizeof(sh_if_name)); + if (ret == -E2BIG) { + DPAA_PMD_ERR("%s: " DRIVER_SH_IF_NAME " longer than %d, ignored", + dpaa_intf->name, IFNAMSIZ - 1); + ret = 0; + } else if (ret < 0) { + DPAA_PMD_ERR("%s: failed(%d) to parse " DRIVER_SH_IF_NAME ", ignored", + dpaa_intf->name, ret); + ret = 0; + } + if (ret <= 0 || sh_if_name[0] == '\0') + strlcpy(ifr.ifr_name, dpaa_intf->name, IFNAMSIZ); + else + strlcpy(ifr.ifr_name, sh_if_name, IFNAMSIZ); if (ioctl(socket_fd, SIOCGIFMTU, &ifr) < 0) { DPAA_PMD_ERR("Cannot get interface mtu"); @@ -2348,6 +2370,53 @@ dpaa_get_devargs_int(struct rte_devargs *devargs, const char *key, long *val) return 1; } +static int +parse_str_devarg_handler(__rte_unused const char *key, const char *value, + void *opaque) +{ + *(const char **)opaque = value; + return 0; +} + +/* + * Fetch a string valued device argument into a caller-supplied buffer. + * Returns 1 and copies the value into val (up to size bytes, NUL-terminated) + * if the key is present, 0 if the key is absent, and a negative errno on error. + */ +static int +dpaa_get_devargs_str(struct rte_devargs *devargs, const char *key, + char *val, size_t size) +{ + struct rte_kvargs *kvlist; + const char *str = NULL; + int ret; + + if (!devargs) + return 0; + + kvlist = rte_kvargs_parse(devargs->args, NULL); + if (!kvlist) + return 0; + + if (!rte_kvargs_count(kvlist, key)) { + rte_kvargs_free(kvlist); + return 0; + } + + ret = rte_kvargs_process(kvlist, key, parse_str_devarg_handler, &str); + if (ret < 0 || str == NULL) { + rte_kvargs_free(kvlist); + return ret < 0 ? ret : 0; + } + + ret = rte_strscpy(val, str, size); + rte_kvargs_free(kvlist); + if (ret < 0) + return ret; + + return 1; +} + /* Initialise a network interface */ static int dpaa_dev_init(struct rte_eth_dev *eth_dev) @@ -2960,5 +3029,6 @@ RTE_PMD_REGISTER_PARAM_STRING(net_dpaa, DRIVER_RECV_ERR_PKTS "= " DRIVER_RX_TAILDROP "= " DRIVER_TX_TAILDROP "= " - DRIVER_FMCLESS_RXQ "="); + DRIVER_FMCLESS_RXQ "= " + DRIVER_SH_IF_NAME "="); RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_pmd, NOTICE); -- 2.25.1