From: Roman Khromenok <roma55592@yandex.ru>
To: dev@dpdk.org
Cc: thomas@monjalon.net, stephen@networkplumber.org,
andrew.rybchenko@oktetlabs.ru
Subject: Re: [PATCH v2 0/4] ethdev: report module signal status flags
Date: Fri, 9 Oct 2026 22:57:41 +0200 [thread overview]
Message-ID: <20261009205741.550421-1-roma55592@yandex.ru> (raw)
In-Reply-To: <QfuRvLIpRPi5pHmcYtqGrA@monjalon.net>
On Fri, 9 Oct 2026, Thomas Monjalon wrote:
> This is specific to networking devices, right?
> So it has to be linked with ethdev probably.
> But if it is not specific to any driver,
> we may consider moving it to separate library.
> I'm not sure which place is best.
Yes, these are the pluggable transceivers of network ports, but
nothing in the decoding is driver specific. Drivers only return
the raw EEPROM bytes through the get_module_eeprom op, and the
decoding follows the SFF specifications. The decoder (about 2700
lines) uses ethdev only for the RTE_ETH_MODULE_SFF_* type values
and the callback typedef.
So ethdev would keep linking it, the same way it depends on net
and meter: ethdev depends on the new library, not the other way.
rte_eth_dev_get_module_eeprom() and the telemetry command stay
in ethdev and call the library.
The decoder is also useful for ports which are not ethdev ports:
in our firewall, the kernel ports are read with the ethtool ioctls
and decoded with a copy of the same code. This already works with
rte_eth_module_eeprom_parse(), so a separate library is mostly
about keeping ethdev smaller, especially when CMIS is added,
which is about the size of the SFF-8636 decoder.
Keeping it in ethdev is fine with me too. If you prefer that,
I will add CMIS there.
next prev parent reply other threads:[~2026-10-09 20:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 8:23 [PATCH 0/4] ethdev: report module signal status flags Roman Khromenok
2026-10-08 8:23 ` [PATCH 1/4] ethdev: report SFF-8636 lane " Roman Khromenok
2026-10-08 8:23 ` [PATCH 2/4] test: check " Roman Khromenok
2026-10-08 8:23 ` [PATCH 3/4] ethdev: report SFF-8472 Rx LOS and Tx fault state Roman Khromenok
2026-10-08 8:23 ` [PATCH 4/4] test: check " Roman Khromenok
2026-10-08 17:45 ` [PATCH 0/4] ethdev: report module signal status flags Stephen Hemminger
2026-10-08 18:02 ` [PATCH v2 " Roman Khromenok
2026-10-08 18:02 ` [PATCH v2 1/4] ethdev: report SFF-8636 lane " Roman Khromenok
2026-10-08 18:02 ` [PATCH v2 2/4] test: check " Roman Khromenok
2026-10-08 18:02 ` [PATCH v2 3/4] ethdev: report SFF-8472 Rx LOS and Tx fault state Roman Khromenok
2026-10-08 18:02 ` [PATCH v2 4/4] test: check " Roman Khromenok
2026-10-09 18:22 ` [PATCH v2 0/4] ethdev: report module signal status flags Stephen Hemminger
2026-10-09 19:21 ` Roman Khromenok
2026-10-09 20:34 ` Thomas Monjalon
2026-10-09 20:57 ` Roman Khromenok [this message]
2026-10-09 21:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009205741.550421-1-roma55592@yandex.ru \
--to=roma55592@yandex.ru \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox