From: Stephen Hemminger <stephen@networkplumber.org>
To: Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>
Cc: <dev@dpdk.org>, Jakub Grajciar <jgrajcia@cisco.com>, <stable@dpdk.org>
Subject: Re: [PATCH v4 0/9] net/memif: lifecycle fixes and unit test
Date: Sat, 17 Oct 2026 14:17:24 -0700 [thread overview]
Message-ID: <20261017141724.3723038b@phoenix.local> (raw)
In-Reply-To: <20261016195857.3258796-1-sriram.yagnaraman@ericsson.com>
On Fri, 16 Oct 2026 21:58:48 +0200
Sriram Yagnaraman <sriram.yagnaraman@ericsson.com> wrote:
> This series fixes a set of error-path and lifecycle bugs in the memif
> PMD and adds a unit test for the driver.
>
> The first eight patches are fixes:
>
> - guard eth_memif_tx() against an empty burst (nb_pkts == 0);
> - close file descriptor 0 instead of leaking it;
> - do not close the EAL-owned memseg fd in zero-copy mode;
> - free the MAC address allocated during probe on failure;
> - unwind a partially-created device on create failure;
> - refuse connections on a stopped server so it does not come up on a
> stopped port;
> - disconnect on close so a stopped server's control channel is not
> leaked, and make memif_disconnect() safe on a never-started device;
> - fix eth_memif_tx_zc() returning 65535 on an invalid interrupt fd.
>
> The last patch adds a memif PMD unit test (app/test, memif_pmd_autotest):
> a server/client vdev pair over a loopback socket covering dev_info, link
> state, stats, single-segment loopback (slow and fast path), multi-segment
> loopback across a ring wrap, stop/start reconnect, empty Tx burst, close
> without stop, and a stopped server refusing a peer.
>
> Verified: memif_pmd_autotest passes 11/11 (~1.4s); devtools/test-memif.sh
> two-process forwarding OK; each commit builds with -Dwerror=true;
> check-git-log and checkpatch are clean.
>
> Thanks to Stephen Hemminger and the ai-code-review bot for the reviews
> that shaped this series.
Applied to next-net.
prev parent reply other threads:[~2026-10-17 21:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 19:58 [PATCH v4 0/9] net/memif: lifecycle fixes and unit test Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 1/9] net/memif: guard against empty Tx burst Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 2/9] net/memif: close file descriptor zero Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 3/9] net/memif: do not close EAL-owned memseg file descriptor Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 4/9] net/memif: fix MAC address leak on probe failure Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 5/9] net/memif: unwind partial device on create failure Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 6/9] net/memif: refuse connection on stopped device Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 7/9] net/memif: disconnect on device close Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 8/9] net/memif: fix bogus Tx count on invalid interrupt FD Sriram Yagnaraman
2026-10-16 19:58 ` [PATCH v4 9/9] test/memif: add memif PMD unit test Sriram Yagnaraman
2026-10-17 21:17 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261017141724.3723038b@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=sriram.yagnaraman@ericsson.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox