DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Goodkind <alex@goodkind.io>
To: dpdklab@iol.unh.edu, kishore.padmanabha@broadcom.com,
	ajit.khaparde@broadcom.com
Cc: dev@dpdk.org, test-report@dpdk.org, stable@dpdk.org,
	thomas@monjalon.net, tarick@bedeir.com
Subject: Re: |WARNING| [v2] net/bnxt: fix aliasing in firmware command writes
Date: Sat, 17 Oct 2026 20:02:49 -0700	[thread overview]
Message-ID: <20261018030249.80449-1-alex@goodkind.io> (raw)
In-Reply-To: <20261018024910.5D1706051830@postal.iol.unh.edu>

> On the last iteration when i + 4 > msg_len, only msg_len - i bytes
> are copied.

The copy length is sizeof(request_word), so memcpy initializes the
entire uint32_t before rte_write32(). It does not shorten the copy
based on msg_len. The previous pointer dereference also read a full
uint32_t.

> Missing release notes update

Comparable fixes, including the enic aliasing fix [1] and the checksum
memcpy fix [2], did not include release-note entries. I followed that
precedent here, but I can add a release-note entry if the maintainers
would prefer one.

[1] https://github.com/DPDK/dpdk/commit/7895d17cf41094cb7d5ad67f484dd492f5a643bf
[2] https://github.com/DPDK/dpdk/commit/1c9a7fba5c90e0422b517404499ed106f647bcff

  parent reply	other threads:[~2026-10-18  3:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18  1:49 [PATCH] net/bnxt: fix aliasing in firmware command writes Alexander Goodkind
2026-10-18  2:29 ` [PATCH v2] " Alexander Goodkind
     [not found]   ` <20261018024910.5D1706051830@postal.iol.unh.edu>
2026-10-18  3:02     ` Alexander Goodkind [this message]
2026-10-19 11:32       ` |WARNING| [v2] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018030249.80449-1-alex@goodkind.io \
    --to=alex@goodkind.io \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=dpdklab@iol.unh.edu \
    --cc=kishore.padmanabha@broadcom.com \
    --cc=stable@dpdk.org \
    --cc=tarick@bedeir.com \
    --cc=test-report@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox