From: Stephen Hemminger <stephen@networkplumber.org>
To: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
Cc: Joshua Washington <joshwash@google.com>,
dev@dpdk.org, stable@dpdk.org,
Jeroen de Borst <jeroendb@google.com>,
Rushil Gupta <rushilg@google.com>,
Junfeng Guo <junfengg@nvidia.com>
Subject: Re: [PATCH v4 09/10] net/gve: enforce DQO Tx packet length limits
Date: Mon, 19 Oct 2026 09:55:00 -0700 [thread overview]
Message-ID: <20261019095500.5b577674@phoenix.local> (raw)
In-Reply-To: <CA++LmPX3NA0=qOs=p7m8=4Zxq-=gLdgMJA=EKJy=SxNKysqfwQ@mail.gmail.com>
On Sun, 18 Oct 2026 13:24:03 +0530
Tathagat Priyadarshi <tathagat.dpdk@gmail.com> wrote:
> > > +static inline bool
> > > +gve_tx_validate_pkt(const struct rte_mbuf *tx_pkt, bool is_tso)
> >
> > Minor nit (not worth blocking over, but maybe can be done as the
> > patches are being merged): can this be renamed to
> > gve_tx_validate_pkt_len? This is one step of many in the packet
> > validation pipeline.
>
> Thanks for the review, Joshua. Agreed on renaming to gve_tx_validate_pkt_len.
> This change impacts patches 9/10 and 10/10. I am happy to submit a v5
> series if preferred,
> or the maintainer can rename it upon applying.
Renames should go through patchwork. I can cleanup commit messages and
release notes, that is where I stop.
next prev parent reply other threads:[~2026-10-19 16:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 17:45 [PATCH v4 00/10] net/gve: fix DQO Tx queue stalls Tathagat Priyadarshi
2026-10-16 17:45 ` [PATCH v4 01/10] net/gve: fix DQO descriptor cleaning loop bound Tathagat Priyadarshi
2026-10-16 17:45 ` [PATCH v4 02/10] net/gve: fix DQO completion queue stall on unknown type Tathagat Priyadarshi
2026-10-16 17:45 ` [PATCH v4 03/10] net/gve: fix DQO Tx report event interval Tathagat Priyadarshi
2026-10-16 17:45 ` [PATCH v4 04/10] net/gve: fix stray TSO context descriptor on tag exhaustion Tathagat Priyadarshi
2026-10-16 17:45 ` [PATCH v4 05/10] net/gve: add cacheline overlap margin to DQO Tx ring Tathagat Priyadarshi
2026-10-16 17:45 ` [PATCH v4 06/10] net/gve: fix Tx stall on invalid packets Tathagat Priyadarshi
2026-10-16 17:45 ` [PATCH v4 07/10] net/gve: export Tx drop counters in xstats Tathagat Priyadarshi
2026-10-16 18:18 ` Joshua Washington
2026-10-16 17:45 ` [PATCH v4 08/10] net/gve: reject Tx packets that cannot fit in the ring Tathagat Priyadarshi
2026-10-16 18:18 ` Joshua Washington
2026-10-16 17:45 ` [PATCH v4 09/10] net/gve: enforce DQO Tx packet length limits Tathagat Priyadarshi
2026-10-16 18:22 ` Joshua Washington
2026-10-18 7:54 ` Tathagat Priyadarshi
2026-10-19 16:55 ` Stephen Hemminger [this message]
2026-10-19 17:35 ` Joshua Washington
2026-10-16 17:45 ` [PATCH v4 10/10] net/gve: enforce DQO TSO header and " Tathagat Priyadarshi
2026-10-16 18:33 ` Joshua Washington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019095500.5b577674@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=junfengg@nvidia.com \
--cc=rushilg@google.com \
--cc=stable@dpdk.org \
--cc=tathagat.dpdk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox