From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stephen@networkplumber.org, hkalra@marvell.com,
Anatoly Burakov <anatoly.burakov@intel.com>,
Chenbo Xia <chenbox@nvidia.com>,
Nipun Gupta <nipun.gupta@amd.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: [PATCH 4/9] bus/pci: reset VFIO device FD after release
Date: Wed, 21 Oct 2026 11:23:13 +0200 [thread overview]
Message-ID: <20261021092318.1554295-5-david.marchand@redhat.com> (raw)
In-Reply-To: <20261021092318.1554295-1-david.marchand@redhat.com>
From: Stephen Hemminger <stephen@networkplumber.org>
The VFIO device fd is closed by dev_vfio_release_device() but is left
in the interrupt handle, so freeing the handle on cleanup logs a bogus
FD leak warning.
Mark dev_fd invalid after release.
In secondary process the request handle is unused and does not have to
be set in the first place.
Fixes: d770ee9caed0 ("interrupts: warn on leaked FDs")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/bus/pci/linux/pci_vfio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c
index fb35bc1d49..c81d20200d 100644
--- a/drivers/bus/pci/linux/pci_vfio.c
+++ b/drivers/bus/pci/linux/pci_vfio.c
@@ -998,8 +998,6 @@ pci_vfio_map_resource_secondary(struct rte_pci_device *dev)
/* we need save vfio_dev_fd, so it can be used during release */
if (rte_intr_dev_fd_set(dev->intr_handle, vfio_dev_fd))
goto err_map;
- if (rte_intr_dev_fd_set(dev->vfio_req_intr_handle, vfio_dev_fd))
- goto err_map;
return 0;
err_map:
@@ -1103,6 +1101,7 @@ pci_vfio_unmap_resource_primary(struct rte_pci_device *dev)
PCI_LOG(ERR, "Cannot release VFIO device");
return ret;
}
+ rte_intr_dev_fd_set(dev->intr_handle, -1);
vfio_res_list =
RTE_TAILQ_CAST(dev_vfio_tailq.head, mapped_pci_res_list);
@@ -1142,6 +1141,7 @@ pci_vfio_unmap_resource_secondary(struct rte_pci_device *dev)
PCI_LOG(ERR, "Cannot release VFIO device");
return ret;
}
+ rte_intr_dev_fd_set(dev->intr_handle, -1);
vfio_res_list =
RTE_TAILQ_CAST(dev_vfio_tailq.head, mapped_pci_res_list);
--
2.54.0
next prev parent reply other threads:[~2026-10-21 9:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 9:23 [PATCH 0/9] Interrupt fixes for leaks and warnings David Marchand
2026-10-21 9:23 ` [PATCH 1/9] eal/linux: fix FD leak in alarm subsystem David Marchand
2026-10-21 9:23 ` [PATCH 2/9] eal/linux: reset FD in interrupt handle for uevent David Marchand
2026-10-21 9:23 ` [PATCH 3/9] interrupts: do not duplicate interrupt handles David Marchand
2026-10-21 9:23 ` David Marchand [this message]
2026-10-21 9:23 ` [PATCH 5/9] net/mana: reset FD in interrupt handle David Marchand
2026-10-21 9:23 ` [PATCH 6/9] net/memif: fix some interrupt FD leaks David Marchand
2026-10-21 9:23 ` [PATCH 7/9] net/memif: reset FD in interrupt handle David Marchand
2026-10-21 9:23 ` [PATCH 8/9] net/sxe2: " David Marchand
2026-10-21 9:23 ` [PATCH 9/9] raw/ifpga: " David Marchand
2026-10-24 13:21 ` [PATCH v2 00/12] Interrupt fixes for leaks and warnings David Marchand
2026-10-24 13:21 ` [PATCH v2 01/12] eal/linux: fix FD leak in alarm subsystem David Marchand
2026-10-24 13:21 ` [PATCH v2 02/12] eal/linux: reset FD in interrupt handle for uevent David Marchand
2026-10-24 14:07 ` Burakov, Anatoly
2026-10-24 13:21 ` [PATCH v2 03/12] interrupts: do not duplicate interrupt handles David Marchand
2026-10-24 14:11 ` Burakov, Anatoly
2026-10-26 15:39 ` David Marchand
2026-10-24 13:21 ` [PATCH v2 04/12] bus/pci: reset VFIO device FD after release David Marchand
2026-10-24 14:11 ` Burakov, Anatoly
2026-10-24 13:21 ` [PATCH v2 05/12] net/mana: reset FD in interrupt handle David Marchand
2026-10-24 13:21 ` [PATCH v2 06/12] net/memif: fix some interrupt FD leaks David Marchand
2026-10-24 13:21 ` [PATCH v2 07/12] net/memif: reset FD in interrupt handle David Marchand
2026-10-24 13:21 ` [PATCH v2 08/12] net/sxe2: " David Marchand
2026-10-24 13:21 ` [PATCH v2 09/12] raw/ifpga: " David Marchand
2026-10-24 13:21 ` [PATCH v2 10/12] eal/linux: fix closing of event FDs not owned by EAL David Marchand
2026-10-24 13:21 ` [PATCH v2 11/12] eal/linux: fix eventfd leaks when enabling interrupts David Marchand
2026-10-24 13:21 ` [PATCH v2 12/12] interrupts: warn on leaked event FDs David Marchand
2026-10-27 17:16 ` [PATCH v2 00/12] Interrupt fixes for leaks and warnings David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021092318.1554295-5-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=nipun.gupta@amd.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox