From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7FB79606A31A for ; Fri, 23 Oct 2026 15:58:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=vip.163.com header.i=@vip.163.com header.a=rsa-sha256 header.s=s110527 header.b=C/hTaqmI Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8BD24068A; Fri, 23 Oct 2026 17:58:21 +0200 (CEST) Received: from mail-m16.vip.163.com (mail-m16.vip.163.com [1.95.21.5]) by mails.dpdk.org (Postfix) with ESMTP id 8ACB440265; Fri, 23 Oct 2026 17:58:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vip.163.com; s=s110527; h=From:To:Subject:Date:Message-ID: MIME-Version; bh=9loECt8hrIGh5sy147D10dpfpWo6lWHVJUsm7KRsC00=; b=C/hTaqmIhKVZ2x70Fq77+69lRzna1CM/Ekr6visLuJvhor41UWJgKsnxYS86HJ 4881TQanRJsv+wJ5lhi8Bnko5Nd2ZWtyu0t3t3ngVMjgIXOgvblNCl5C3LUvZu1m qdFo91vH7m9+J71fGwCta1DL/q+wMhOdcT42lXLgpJcyQ= From: Jiacheng Ye To: dev@dpdk.org Cc: Feifei Wang , Thomas Monjalon , Anatoly Burakov , stable@dpdk.org Subject: [PATCH v4 02/27] net/hinic3: fix double removal in ethertype flow destroy Date: Fri, 23 Oct 2026 23:57:43 +0800 Message-ID: <20261023155809.855-3-yejiacheng4@h-partners.com> X-Mailer: git-send-email 2.53.0.windows.2 In-Reply-To: <20261023155809.855-1-yejiacheng4@h-partners.com> References: <20261019151930.1572-1-yejiacheng4@h-partners.com> <20261023155809.855-1-yejiacheng4@h-partners.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: As8vCgAnQEEUhNtqKyfqAw--.15103S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrZrWrZr4rWw4DGw13Xw4Dtwb_yoWDCrg_Cr yI9F17A34qkr48tw1UKr43Z34akr4vqFyIvw4Iqry3G34UAF4IqFyUur4fJas7GF1UZFnx Cr9rK34Ik3s5KjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU01q2tUUUUU== Sender: wff_light@vip.163.com X-CM-SenderInfo: pziiszhljk3qxylshiywtou0bp/1tbiNha3wWrbhBYC2gAA3t X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Archive: List-Post: List-Help: List-Subscribe: , X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The ethertype destroy path removes the same flow node from filter_ethertype_list twice, corrupting the tailq and leading to use-after-free. Drop the redundant removal. Fixes: efa3b9b36fc7 ("net/hinic3: add flow control and filters") Cc: stable@dpdk.org Signed-off-by: Jiacheng Ye --- drivers/net/hinic3/hinic3_flow.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/hinic3/hinic3_flow.c b/drivers/net/hinic3/hinic3_flow.c index 5c255619e3..453b4369b3 100644 --- a/drivers/net/hinic3/hinic3_flow.c +++ b/drivers/net/hinic3/hinic3_flow.c @@ -1332,10 +1332,6 @@ hinic3_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow, &rules->ethertype_filter, false); if (!ret) TAILQ_REMOVE(&nic_dev->filter_ethertype_list, flow, node); - - flow->rule = rules; - flow->filter_type = rules->filter_type; - TAILQ_REMOVE(&nic_dev->filter_ethertype_list, flow, node); break; case RTE_ETH_FILTER_FDIR: -- 2.33.0