From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 75BCC606A31A for ; Fri, 23 Oct 2026 15:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=vip.163.com header.i=@vip.163.com header.a=rsa-sha256 header.s=s110527 header.b=csWdW1tC Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A9C740A89; Fri, 23 Oct 2026 17:58:24 +0200 (CEST) Received: from mail-m16.vip.163.com (mail-m16.vip.163.com [220.197.30.222]) by mails.dpdk.org (Postfix) with ESMTP id AD96940265; Fri, 23 Oct 2026 17:58:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vip.163.com; s=s110527; h=From:To:Subject:Date:Message-ID: MIME-Version; bh=p8z8eoIn9ljkcRoFq9hJlN47t+mxZamkx+UTzgmL2zU=; b=csWdW1tCBKHywsovlKiJULHXmaIYn1sxb6B4OAFAhhlKSrgQM6SYUL5BbE3lt6 L1lGEhb8FiJjHmFUXEDACvLtaIfh/IYaSgIj9M5yJ0xqYAadhTikE5VtigTIH+Tv Hx9CPYi10yTW7+MLDjM3wMtRcD4mPPCYEWRu5ans22BZE= From: Jiacheng Ye To: dev@dpdk.org Cc: Feifei Wang , Thomas Monjalon , Anatoly Burakov , stable@dpdk.org Subject: [PATCH v4 04/27] net/hinic3: fix VXLAN VNI spec and mask write Date: Fri, 23 Oct 2026 23:57:45 +0800 Message-ID: <20261023155809.855-5-yejiacheng4@h-partners.com> X-Mailer: git-send-email 2.53.0.windows.2 In-Reply-To: <20261023155809.855-1-yejiacheng4@h-partners.com> References: <20261019151930.1572-1-yejiacheng4@h-partners.com> <20261023155809.855-1-yejiacheng4@h-partners.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: As8vCgAnQEEUhNtqKyfqAw--.15103S6 X-Coremail-Antispam: 1Uf129KBjvJXoW7CFWxAFy3XrW5CFyxGw47XFb_yoW8XF1xpF 4UG3yDXr4vqFW5Cwnrtw1fAFyYg3s7Jay3CFyDCa4ayryUZryxC3yfG3y2krnxKr1kJFyS yF4UCr4qy3Z0qaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07j7SdgUUUUU= Sender: wff_light@vip.163.com X-CM-SenderInfo: pziiszhljk3qxylshiywtou0bp/1tbiNhe3wWrbhBcC3QAA3q X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Archive: List-Post: List-Help: List-Subscribe: , X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The VXLAN parser writes the flow item spec into key_mask and never populates the mask, so VNI matches against a wrong value. Store the spec into key_spec and the mask into key_mask. Fixes: efa3b9b36fc7 ("net/hinic3: add flow control and filters") Cc: stable@dpdk.org Signed-off-by: Jiacheng Ye --- drivers/net/hinic3/hinic3_flow.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/hinic3/hinic3_flow.c b/drivers/net/hinic3/hinic3_flow.c index 453b4369b3..1f686d4675 100644 --- a/drivers/net/hinic3/hinic3_flow.c +++ b/drivers/net/hinic3/hinic3_flow.c @@ -967,6 +967,7 @@ hinic3_flow_fdir_vxlan(struct rte_flow_error *error, { const struct rte_flow_item_vxlan *spec_vxlan, *mask_vxlan; uint32_t vxlan_vni_id = 0; + uint32_t vxlan_vni_id_mask = 0; spec_vxlan = (const struct rte_flow_item_vxlan *)flow_item->spec; mask_vxlan = (const struct rte_flow_item_vxlan *)flow_item->mask; @@ -990,8 +991,11 @@ hinic3_flow_fdir_vxlan(struct rte_flow_error *error, } memcpy(((uint8_t *)&vxlan_vni_id + 1), spec_vxlan->vni, 3); - filter->fdir_filter.key_mask.tunnel.tunnel_id = + filter->fdir_filter.key_spec.tunnel.tunnel_id = rte_be_to_cpu_32(vxlan_vni_id); + memcpy(((uint8_t *)&vxlan_vni_id_mask + 1), mask_vxlan->vni, 3); + filter->fdir_filter.key_mask.tunnel.tunnel_id = + rte_be_to_cpu_32(vxlan_vni_id_mask); return 0; } -- 2.33.0