From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B0D7606A31A for ; Fri, 23 Oct 2026 15:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=vip.163.com header.i=@vip.163.com header.a=rsa-sha256 header.s=s110527 header.b=O74Ch6Ld Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 637EB40A75; Fri, 23 Oct 2026 17:58:23 +0200 (CEST) Received: from mail-m16.vip.163.com (mail-m16.vip.163.com [1.95.21.2]) by mails.dpdk.org (Postfix) with ESMTP id D91EA40268; Fri, 23 Oct 2026 17:58:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vip.163.com; s=s110527; h=From:To:Subject:Date:Message-ID: MIME-Version; bh=/Jp/qNjmNdWGe1vmrDFnwDLCkzrHUkbIZknsC9dQLyA=; b=O74Ch6Ldk78Fc8znsAO7QGOESH905EmLFKj7/WKE7/dFiZmDDc+MX4nHTKtdRe TBILsun2Otsl8gkz+D4NB7qx8C73Bx21l3piAbWCsPA/4d9PGgzAA/kpi3kE2aci VxCeoO9Fx3IdRge6vns1fyQS0TU+SOhlHx2LRUgN+uaPs= From: Jiacheng Ye To: dev@dpdk.org Cc: Feifei Wang , Thomas Monjalon , Anatoly Burakov , stable@dpdk.org Subject: [PATCH v4 05/27] net/hinic3: fix vport enable null dereference Date: Fri, 23 Oct 2026 23:57:46 +0800 Message-ID: <20261023155809.855-6-yejiacheng4@h-partners.com> X-Mailer: git-send-email 2.53.0.windows.2 In-Reply-To: <20261023155809.855-1-yejiacheng4@h-partners.com> References: <20261019151930.1572-1-yejiacheng4@h-partners.com> <20261023155809.855-1-yejiacheng4@h-partners.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: As8vCgAnQEEUhNtqKyfqAw--.15103S7 X-Coremail-Antispam: 1Uf129KBjvJXoW7Gr45Xr47Xr1UJF4kurWxJFb_yoW8Jr4DpF W7Ka92kr98KF4xtw1DJw18Aa4Y9w1xCa48Ka45A3WYvFn5XF1Yy3y7trZ2vr1avrWxAFW2 9F4I9a1qvryDt37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jzrWrUUUUU= Sender: wff_light@vip.163.com X-CM-SenderInfo: pziiszhljk3qxylshiywtou0bp/1tbiMhe3wWrbhBfihAAA3X X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Archive: List-Post: List-Help: List-Subscribe: , X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 hinic3_set_vport_enable() dereferences hwdev->dev_handle before checking hwdev, and then uses nic_dev without validating it. Guard both pointers to avoid a NULL dereference during early PF initialization. Fixes: de490215f74a ("net/hinic3: add NIC configuration module") Cc: stable@dpdk.org Signed-off-by: Jiacheng Ye --- drivers/net/hinic3/base/hinic3_nic_cfg.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/hinic3/base/hinic3_nic_cfg.c b/drivers/net/hinic3/base/hinic3_nic_cfg.c index 5387626b98..d64a123c56 100644 --- a/drivers/net/hinic3/base/hinic3_nic_cfg.c +++ b/drivers/net/hinic3/base/hinic3_nic_cfg.c @@ -443,12 +443,15 @@ int hinic3_set_vport_enable(struct hinic3_hwdev *hwdev, bool enable) { struct hinic3_vport_state en_state; - struct hinic3_nic_dev *nic_dev = hwdev->dev_handle; + struct hinic3_nic_dev *nic_dev; uint16_t out_size = sizeof(en_state); int err; if (!hwdev) return -EINVAL; + nic_dev = hwdev->dev_handle; + if (!nic_dev) + return -EINVAL; memset(&en_state, 0, sizeof(en_state)); en_state.func_id = hinic3_global_func_id(hwdev); -- 2.33.0