DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Khromenok <roma55592@yandex.ru>
Cc: dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru,
	aman.deep.singh@intel.com
Subject: Re: [PATCH 0/4] move module EEPROM decoding to a transceiver library
Date: Thu, 29 Oct 2026 13:52:48 -0700	[thread overview]
Message-ID: <20261029135248.6d813f58@phoenix.local> (raw)
In-Reply-To: <20261029181511.1736967-1-roma55592@yandex.ru>

On Thu, 29 Oct 2026 20:15:07 +0200
Roman Khromenok <roma55592@yandex.ru> wrote:

> This is the follow-up of the RFC, for 27.03.
> 
> The SFF module EEPROM decoders do not depend on any device or driver,
> and they are also useful for ports which are not ethdev ports, such as
> kernel ports read with the ethtool ioctls. This series moves them from
> ethdev to a new transceiver library with the rte_transceiver_decode()
> API. ethdev depends on the library for its telemetry command.
> 
> Changes since the RFC, as discussed with Thomas:
> - rte_eth_module_eeprom_parse(), added as experimental in 26.11,
>   is removed instead of being kept as a wrapper.
> - testpmd calls rte_transceiver_decode() directly.
> - The tests no longer depend on ethdev.
> - The ethdev guide links to the library guide instead of
>   duplicating the example.
> 
> The library name is still "transceiver", as it reads better than
> "xcvr". It can be renamed if preferred.
> 
> Release notes will be added when the 27.03 release notes exist.
> 
> The dpdk-proc-info module EEPROM decoding (series 39575) will be
> sent as a v2 on top of this series.
> 
> Tested with gcc, and clang with ASan and UBSan: every patch builds
> without warnings, transceiver_autotest passes, the documentation
> builds without warnings, and the testpmd command decodes a module.
> 
> RFC: https://mails.dpdk.org/archives/dev/2026-October/348542.html

Manual AI review:

Subject: Re: [PATCH 0/4] transceiver: module EEPROM decoding library

Patch 1/4 transceiver: introduce module EEPROM decoding library

Warning: no release note for the new library. Add a New Features
entry to the 27.03 release notes, for example:

  * **Added transceiver library.**

    Added the experimental transceiver library to decode pluggable
    module EEPROM data according to the SFF-8079, SFF-8472, SFF-8436
    and SFF-8636 specifications. ``rte_transceiver_decode()`` can
    decode data read with ``rte_eth_dev_get_module_eeprom()`` or
    obtained from any other source with the same layout, such as the
    Linux ethtool ``ETHTOOL_GMODULEEEPROM`` ioctl.

Info: lib/transceiver/meson.build sources are not in alphabetical
order; 'sff_8079.c', 'sff_8472.c', 'sff_8636.c' sort before
'sff_common.c'.


Patch 4/4 ethdev: remove module EEPROM decoding wrapper

Warning: rte_eth_module_eeprom_parse() ships in 26.11 and is removed
here without a release note. Add a Removed Items entry to the 27.03
release notes:

  * ethdev: Removed the experimental function
    ``rte_eth_module_eeprom_parse()``
    and the ``rte_eth_module_eeprom_field_cb`` type,
    replaced by ``rte_transceiver_decode()``
    from the transceiver library.


      parent reply	other threads:[~2026-10-29 20:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  7:12 [RFC 0/2] move module EEPROM decoding to a transceiver library Roman Khromenok
2026-10-14  7:12 ` [RFC 1/2] transceiver: introduce module EEPROM decoding library Roman Khromenok
2026-10-14  7:12 ` [RFC 2/2] test/transceiver: move module EEPROM decoding tests Roman Khromenok
2026-10-26 20:09 ` [RFC 0/2] move module EEPROM decoding to a transceiver library Roman Khromenok
2026-10-29 16:11   ` Thomas Monjalon
2026-10-29 17:41     ` Roman Khromenok
2026-10-29 18:15 ` [PATCH 0/4] " Roman Khromenok
2026-10-29 18:15   ` [PATCH 1/4] transceiver: introduce module EEPROM decoding library Roman Khromenok
2026-10-29 18:15   ` [PATCH 2/4] test/transceiver: move module EEPROM decoding tests Roman Khromenok
2026-10-29 18:15   ` [PATCH 3/4] app/testpmd: decode module EEPROM with transceiver library Roman Khromenok
2026-10-29 18:15   ` [PATCH 4/4] ethdev: remove module EEPROM decoding wrapper Roman Khromenok
2026-10-29 20:52   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029135248.6d813f58@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=roma55592@yandex.ru \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox