DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bing Zhao <bingz@nvidia.com>
Cc: <dev@dpdk.org>, Frank Dressler <frank@dressler.pro>,
	Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>,
	Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [PATCH v2] net/af_packet: fix build with old kernel headers
Date: Tue, 10 Nov 2026 08:51:32 -0800	[thread overview]
Message-ID: <20261110085132.67619c96@phoenix.local> (raw)
In-Reply-To: <20261109154730.146345-1-bingz@nvidia.com>

On Mon, 9 Nov 2026 17:47:30 +0200
Bing Zhao <bingz@nvidia.com> wrote:

> The PACKET_IGNORE_OUTGOING socket option is used unconditionally,
> but it was only added to the uapi headers in Linux 4.20. The build
> fails on distributions shipping older kernel headers, like RHEL 8
> (kernel-headers 4.18.0):
> 
>   rte_eth_af_packet.c:1057:41: error: 'PACKET_IGNORE_OUTGOING'
>     undeclared (first use in this function)
> 
> DPDK requires Linux 5.4, so the driver does not need to support older
> kernels. Check for the symbol at configure time and skip the driver
> when the headers lack it, instead of failing the whole build.
> 
> Fixes: 3db7aa7868b2 ("net/af_packet: use kernel to filter single-queue Rx")
> 
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> ---

I liked the v1 better, looks simplest

      parent reply	other threads:[~2026-11-10 16:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 14:27 [PATCH] net/af_packet: fix build with old kernel headers Bing Zhao
2026-11-06 14:46 ` Thomas Monjalon
2026-11-06 16:06 ` Frank Dressler
2026-11-07 11:11   ` Frank Dressler
2026-11-08 16:22     ` Stephen Hemminger
2026-11-08 18:51       ` Frank Dressler
2026-11-08 20:29         ` Stephen Hemminger
2026-11-09 15:47 ` [PATCH v2] " Bing Zhao
2026-11-09 17:47   ` Stephen Hemminger
2026-11-10 10:39     ` Thomas Monjalon
2026-11-10 12:52       ` Frank Dressler
2026-11-10 13:56         ` Thomas Monjalon
2026-11-10 14:23           ` Frank Dressler
2026-11-10 16:51   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110085132.67619c96@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=bingz@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=frank@dressler.pro \
    --cc=ktraynor@redhat.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox