From: Mark Bulatov <ms.bulatov7@gmail.com>
To: "Chaoyong He" <chaoyong.he@corigine.com>,
"Niklas Söderlund" <niklas.soderlund@corigine.com>
Cc: dev@dpdk.org, stable@dpdk.org, Mark Bulatov <ms.bulatov7@gmail.com>
Subject: [PATCH v2] net/nfp: fix wrong argument order in nfp_encode_basic
Date: Mon, 16 Nov 2026 20:20:37 +0300 [thread overview]
Message-ID: <20261116172037.5347-1-ms.bulatov7@gmail.com> (raw)
The function nfp_encode_basic_qdr() takes cpp_tgt as its second argument
and dest_island as its third. However, the implementation of this function
implies the opposite: dest_island should be the second argument, and
cpp_tgt the third.
nfp_encode_basic_qdr() takes dest_island as its second argument and
cpp_tgt as its third, but all callers in nfp_encode_basic() pass them
in the opposite order. As a result nfp_decode_basic() gets the island
ID as the target, and the island check compares against NFP_CPP_TARGET_QDR
instead of the requested island.
Fix this by swapping the arguments.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: e6858e7e7cd3 ("net/nfp: move shared target logic to own file")
Cc: stable@dpdk.org
Signed-off-by: Mark Bulatov <ms.bulatov7@gmail.com>
---
v2 changes: Correction of the 'Fixes' tag and description
v1 link:
https://patches.dpdk.org/project/dpdk/patch/20261113142823.5918-1-ms.bulatov7@gmail.com/
drivers/net/nfp/nfpcore/nfp_target.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_target.c b/drivers/net/nfp/nfpcore/nfp_target.c
index 0e7a5cbb05..239ffff869 100644
--- a/drivers/net/nfp/nfpcore/nfp_target.c
+++ b/drivers/net/nfp/nfpcore/nfp_target.c
@@ -728,7 +728,7 @@ nfp_encode_basic(uint64_t *addr,
* address but we can verify if the existing contents
* will point to a valid island.
*/
- return nfp_encode_basic_qdr(*addr, cpp_tgt, dest_island,
+ return nfp_encode_basic_qdr(*addr, dest_island, cpp_tgt,
mode, addr40, isld1, isld0);
}
@@ -741,7 +741,7 @@ nfp_encode_basic(uint64_t *addr,
return 0;
case 1:
if (cpp_tgt == NFP_CPP_TARGET_QDR && addr40 == 0) {
- return nfp_encode_basic_qdr(*addr, cpp_tgt, dest_island,
+ return nfp_encode_basic_qdr(*addr, dest_island, cpp_tgt,
mode, addr40, isld1, isld0);
}
@@ -763,7 +763,7 @@ nfp_encode_basic(uint64_t *addr,
if (cpp_tgt == NFP_CPP_TARGET_QDR && addr40 == 0) {
/* iid<0> = addr<30> = channel<0> */
/* channel<1> = addr<31> = Index */
- return nfp_encode_basic_qdr(*addr, cpp_tgt, dest_island,
+ return nfp_encode_basic_qdr(*addr, dest_island, cpp_tgt,
mode, addr40, isld1, isld0);
}
@@ -786,7 +786,7 @@ nfp_encode_basic(uint64_t *addr,
* iid<1> = addr<30> = channel<0>
* channel<1> = addr<31> = Index
*/
- return nfp_encode_basic_qdr(*addr, cpp_tgt, dest_island,
+ return nfp_encode_basic_qdr(*addr, dest_island, cpp_tgt,
mode, addr40, isld1, isld0);
}
--
2.39.5
next reply other threads:[~2026-11-17 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 17:20 Mark Bulatov [this message]
2026-11-17 18:55 ` [PATCH v2] net/nfp: fix wrong argument order in nfp_encode_basic Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116172037.5347-1-ms.bulatov7@gmail.com \
--to=ms.bulatov7@gmail.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox