From: Stephen Hemminger <stephen@networkplumber.org>
To: "Renyong Wan" <wanry@yunsilicon.com>
Cc: <dev@dpdk.org>, <nana@yunsilicon.com>, <qianr@yunsilicon.com>,
<zhangxx@yunsilicon.com>, <xudw@yunsilicon.com>
Subject: Re: [PATCH v4 0/3] net/xsc: fix issues reported by GCC analyzer
Date: Tue, 17 Nov 2026 09:04:32 -0800 [thread overview]
Message-ID: <20261117090432.5fe1115b@phoenix.local> (raw)
In-Reply-To: <1794914060.606144@yunsilicon.com>
On Tue, 17 Nov 2026 19:14:20 +0800
"Renyong Wan" <wanry@yunsilicon.com> wrote:
> v4:
> - free the jumbo buffer only when the last representor stops the device, it
> is shared by every port and their Rx queues still point at it
>
> v3:
> - free the jumbo buffer in xsc_dev_close(), the device removal path does not
> go through xsc_dev_uninit()
> - drop the redundant parentheses reported by checkpatch, no functional
> change
>
> v2:
> - address the AI review of v1: allocate the jumbo buffer once per device,
> fail the queue setup when there is no IOVA, and free it on device close
> - fix the leak in xsc_dev_init() and the unchecked rte_malloc_socket()
> - rename the jumbo buffer fields, they held the opposite of what their
> names say
>
> Renyong Wan (3):
> net/xsc: fix jumbo buffer allocation and leak
> net/xsc: fix leak and missing null check
> net/xsc: rename jumbo buffer fields
>
> drivers/net/xsc/xsc_dev.c | 17 ++++++++++--
> drivers/net/xsc/xsc_dev.h | 4 +--
> drivers/net/xsc/xsc_ethdev.c | 6 ++++
> drivers/net/xsc/xsc_rx.c | 53 ++++++++++++++++++++----------------
> 4 files changed, 51 insertions(+), 29 deletions(-)
Too late for 26.11 but added to next-net to be picked up in 27.03
prev parent reply other threads:[~2026-11-17 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 11:14 [PATCH v4 0/3] net/xsc: fix issues reported by GCC analyzer Renyong Wan
2026-11-17 11:14 ` [PATCH v4 1/3] net/xsc: fix jumbo buffer allocation and leak Renyong Wan
2026-11-17 11:14 ` [PATCH v4 3/3] net/xsc: rename jumbo buffer fields Renyong Wan
2026-11-17 11:14 ` [PATCH v4 2/3] net/xsc: fix leak and missing null check Renyong Wan
2026-11-17 17:04 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117090432.5fe1115b@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=nana@yunsilicon.com \
--cc=qianr@yunsilicon.com \
--cc=wanry@yunsilicon.com \
--cc=xudw@yunsilicon.com \
--cc=zhangxx@yunsilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox