From: Stephen Hemminger <stephen@networkplumber.org>
To: Ajit Kumar <Ajit.Kumar@amd.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2] net/axgbe: serialize PHY and link status access
Date: Wed, 18 Nov 2026 19:15:21 -0800 [thread overview]
Message-ID: <20261118191521.6f272ebe@phoenix.local> (raw)
In-Reply-To: <20261117094805.4134371-1-Ajit.Kumar@amd.com>
On Tue, 17 Nov 2026 15:18:05 +0530
Ajit Kumar <Ajit.Kumar@amd.com> wrote:
> From: Ajit Kumar <ajit.kumar@amd.com>
>
> The I2C and MDIO buses are shared by all ports on the device.
> axgbe_phy_get_comm_ownership() takes the per-port phy_mutex, which
> does not stop two ports in the same process from using the bus at
> once, causing I2C failures (-EAGAIN, -ENOTCONN, -ETIMEDOUT) and
> incorrect link status reporting.
>
> Add a driver-wide mutex taken before the per-port one, as the Linux
> xgbe driver does (xgbe_phy_comm_lock), which this DPDK PMD lost when
> its equivalent global lock became the per-port pdata->phy_mutex.
>
> This fix applies to ports owned by a single process. If ports of the
> same device are ever split across separate processes, or one port
> stays with the kernel xgbe driver, the hardware mutex registers
> remain the only arbitration between them; this is a pre-existing
> limitation, not something this patch changes.
Applied to next-net for 27.03 but I trimmed the commit message down.
The version change should be below cutline --- and the link status
part was not here anymore
prev parent reply other threads:[~2026-11-19 3:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 13:56 [PATCH] net/axgbe: serialize PHY and link status access Ajit Kumar
2026-11-15 21:23 ` Stephen Hemminger
2026-11-17 9:48 ` [PATCH v2] " Ajit Kumar
2026-11-19 3:15 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118191521.6f272ebe@phoenix.local \
--to=stephen@networkplumber.org \
--cc=Ajit.Kumar@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox