On Thu, 19 Nov 2026 09:21:40 +0530 Ajit Kumar wrote: > > +/* > + * The very first I2C transaction a port issues against its SFP cage > + * (GPIO-expander / mux), right after axgbe_phy_init(), can legitimately > + * find that device not yet ready to respond -- observed in the field > + * as either a quick NACK (-ENOTCONN, IC_TX_ABRT_7B_ADDR_NOACK) or a > + * full hardware stall with zero bus activity until axgbe_i2c_xfer()'s > + * own 1-second timeout fires (-ETIMEDOUT). This is distinct from the > + * cross-port bus-contention race fixed by axgbe_i2c_mdio_bus_mutex in > + * axgbe_phy_get_comm_ownership(): it reproduces on a single port with > + * no other port active at all, immediately after that port's own > + * phy_init(), so serializing the bus does not help with it. > + * > + * Retry on these two codes as well as the existing -EAGAIN, with a > + * short settle delay first, since an immediate retry is unlikely to > + * help if the device is still completing its own power-on sequence. > + * > + * Cost: on the -ETIMEDOUT path this adds up to one more full internal > + * 1-second timeout per phase for a genuinely persistent (non- > + * transient) fault. This is bounded to each port's first post-init > + * access -- a one-time bring-up cost, not a recurring one paid on > + * every subsequent link_update() poll -- and, like any I2C/MDIO bus > + * access, runs while axgbe_i2c_mdio_bus_mutex is held, so it can > + * delay other ports' bus access by the same amount, same as any other > + * access to this bus. > + * > + * Validated on two independent physical units (AMD CRB V3C48 and > + * Advantech FWA-1081): 0 I2C errors across 30 iterations of the > + * original cross-port repro plus a dedicated solo-access repro, which > + * now links up cleanly on both ports; both failed deterministically > + * without this change. > + */ > +static inline bool axgbe_i2c_retryable(int ret) > +{ > + return ret == -EAGAIN || ret == -ENOTCONN || ret == -ETIMEDOUT; > +} The code is fine, but this a great example of an AI slop comment! If you coach AI to write better commit messages and comments it will produce something like: /* * The SFP cage mux/GPIO expander may not respond to the first access * after phy_init(), either NACKing (-ENOTCONN) or stalling until the * transfer times out (-ETIMEDOUT). Retry those as well as arbitration * loss (-EAGAIN), after a short delay to let the device settle. */ See attached CLAUDE.md for hints how to help reduce this kind of mess.