From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 13/13] i40e: improve message grepability
Date: Mon, 09 Jan 2017 14:18:58 +0100
Message-ID: <2026939.L9sH03DzKe@xps13>
References: <cover.1481590851.git.mirq-linux@rere.qmqm.pl>
 <9BB6961774997848B5B42BEC655768F810CC0197@SHSMSX103.ccr.corp.intel.com>
 <20170109120255.GA86544@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: Bruce Richardson <bruce.richardson@intel.com>, "Wu,
 Jingjing" <jingjing.wu@intel.com>, Michal Miroslaw <mirq-linux@rere.qmqm.pl>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id A814298
 for <dev@dpdk.org>; Mon,  9 Jan 2017 14:19:00 +0100 (CET)
Received: by mail-wm0-f53.google.com with SMTP id k184so119329370wme.1
 for <dev@dpdk.org>; Mon, 09 Jan 2017 05:19:00 -0800 (PST)
In-Reply-To: <20170109120255.GA86544@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-09 12:02, Bruce Richardson:
> On Wed, Dec 28, 2016 at 03:51:56AM +0000, Wu, Jingjing wrote:
> >=20
> >=20
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Miros=
law
> > > Sent: Tuesday, December 13, 2016 9:08 AM
> > > To: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH 13/13] i40e: improve message grepabili=
ty
> > >=20
> > > Signed-off-by: Micha=C5=82 Miros=C5=82aw <michal.miroslaw@atendes=
oftware.pl>
> > > ---
> > >  drivers/net/i40e/i40e_ethdev.c | 198 +++++++++++++++------------=
--------------
> > >  1 file changed, 73 insertions(+), 125 deletions(-)
> > >=20
> > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i4=
0e_ethdev.c
> > > index 39fbcfe..4d73aca 100644
> > > --- a/drivers/net/i40e/i40e_ethdev.c
> > > +++ b/drivers/net/i40e/i40e_ethdev.c
> > > @@ -763,8 +763,7 @@ i40e_add_tx_flow_control_drop_filter(struct i=
40e_pf
> > > *pf)
> > >  =09=09=09=09pf->main_vsi_seid, 0,
> > >  =09=09=09=09TRUE, NULL, NULL);
> > >  =09if (ret)
> > > -=09=09PMD_INIT_LOG(ERR, "Failed to add filter to drop flow contr=
ol "
> > > -=09=09=09=09  " frames from VSIs.");
> > > +=09=09PMD_INIT_LOG(ERR, "Failed to add filter to drop flow contr=
ol
> > > frames
> > > +from VSIs.");
> > >  }
> >=20
> > You are right, it makes grep easily. But it will break the coding s=
tyle "Line length is recommended to be not more than 80 characters, inc=
luding comments."
> >=20
> > Any comments from committers?
> >=20
> Being able to grep error messages is more important that having lines=

> wrapped at 80 characters. I believe checkpatch ignores long strings w=
hen
> checking line lengths.

I agree keeping strings is more important than checkpatch conformity.
Please, if checkpatch complains, try to tune the script checkpatch.sh.
There are some options to manage strings.