From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/6] igb: change for VMDQ arguments expansion Date: Mon, 03 Nov 2014 19:37:16 +0100 Message-ID: <2027422.tgQyvDmmaG@xps13> References: <1411478047-1251-2-git-send-email-jing.d.chen@intel.com> <1413454046-13407-1-git-send-email-jing.d.chen@intel.com> <1413454046-13407-3-git-send-email-jing.d.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Chen Jing D(Mark)" Return-path: In-Reply-To: <1413454046-13407-3-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-16 18:07, Chen Jing D: > --- a/lib/librte_pmd_e1000/igb_ethdev.c > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > @@ -1286,18 +1286,21 @@ eth_igb_infos_get(struct rte_eth_dev *dev, > dev_info->max_rx_queues = 16; > dev_info->max_tx_queues = 16; > dev_info->max_vmdq_pools = ETH_8_POOLS; > + dev_info->vmdq_queue_num = 16; > break; > > case e1000_82580: > dev_info->max_rx_queues = 8; > dev_info->max_tx_queues = 8; > dev_info->max_vmdq_pools = ETH_8_POOLS; > + dev_info->vmdq_queue_num = 8; > break; > > case e1000_i350: > dev_info->max_rx_queues = 8; > dev_info->max_tx_queues = 8; > dev_info->max_vmdq_pools = ETH_8_POOLS; > + dev_info->vmdq_queue_num = 8; > break; Why not simply set it only once? dev_info->vmdq_queue_num = dev_info->max_rx_queues; -- Thomas