From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 01/11] lib/rte_security: add security
	library
Date: Tue, 24 Oct 2017 22:47:26 +0200
Message-ID: <2031024.JVCIT9oVUT@xps>
References: <20171014221734.15511-1-akhil.goyal@nxp.com>
 <20171024141545.30837-1-akhil.goyal@nxp.com>
 <20171024141545.30837-2-akhil.goyal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com,
 hemant.agrawal@nxp.com, radu.nicolau@intel.com, borisp@mellanox.com,
 aviadye@mellanox.com, sandeep.malik@nxp.com, jerin.jacob@caviumnetworks.com,
 john.mcnamara@intel.com, konstantin.ananyev@intel.com, shahafs@mellanox.com,
 olivier.matz@6wind.com
To: Akhil Goyal <akhil.goyal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 34BF41B7CF
 for <dev@dpdk.org>; Tue, 24 Oct 2017 22:47:28 +0200 (CEST)
In-Reply-To: <20171024141545.30837-2-akhil.goyal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

I am waiting the crypto subtree to be ready before getting this series.

Some last comments below,

24/10/2017 16:15, Akhil Goyal:
> +Security API - EXPERIMENTAL
> +M: Akhil Goyal <akhil.goyal@nxp.com>
> +M: Declan Doherty <declan.doherty@intel.com>
> +F: lib/librte_security/
> +F: doc/guides/prog_guide/rte_security.rst
>  
>  Networking Drivers
>  ------------------

An additional blank line is missing.


> +# build flags
> +CFLAGS += -O3
> +CFLAGS += $(WERROR_FLAGS)

As said by Pablo, please fix the build with LDLIBS.


> +/**
> + * @file rte_security.h
> + *
> + * RTE Security Common Definitions
> + *
> + */

You should add this line:

@b EXPERIMENTAL: this API may change without prior notice


> --- /dev/null
> +++ b/lib/librte_security/rte_security_version.map
> @@ -0,0 +1,13 @@
> +DPDK_17.11 {

The name of this block should be EXPERIMENTAL

> +	global:
> +
> +	rte_security_attach_session;
> +	rte_security_capabilities_get;
> +	rte_security_capability_get;
> +	rte_security_session_create;
> +	rte_security_session_destroy;
> +	rte_security_session_stats_get;
> +	rte_security_session_update;
> +	rte_security_set_pkt_metadata;
> +
> +};

I think you need this line:
	local: *;