From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v12 1/5] lib/librte_power: traffic pattern
	aware power control
Date: Fri, 26 Oct 2018 01:32:22 +0200
Message-ID: <2031223.gnKAPLfQHy@xps>
References: <1539944630-21625-1-git-send-email-liang.j.ma@intel.com>
 <1539947242-16729-1-git-send-email-liang.j.ma@intel.com>
 <2963009.GYir0F1WiB@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, david.hunt@intel.com, lei.a.yao@intel.com,
 ktraynor@redhat.com, marko.kovacevic@intel.com
To: Liang Ma <liang.j.ma@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 4111E5F11
 for <dev@dpdk.org>; Fri, 26 Oct 2018 01:32:24 +0200 (CEST)
In-Reply-To: <2963009.GYir0F1WiB@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/10/2018 01:22, Thomas Monjalon:
> Hi,
> 
> It fails to compile (tried with meson build-gcc-static):
> 
> lib/librte_power/rte_power_empty_poll.h:20:10: fatal error:
> 	rte_timer.h: No such file or directory
> 
> It looks to be fixed with this one-line change:
> 
> --- a/lib/librte_power/meson.build
> +++ b/lib/librte_power/meson.build
> @@ -8,3 +8,4 @@ sources = files('rte_power.c', 'power_acpi_cpufreq.c',
>         'power_kvm_vm.c', 'guest_channel.c',
>         'rte_power_empty_poll.c')
>  headers = files('rte_power.h','rte_power_empty_poll.h')
> +deps += ['timer']


There are also some doxygen issues:

lib/librte_power/rte_power_empty_poll.h:136: warning: Found unknown command `\freq_tlb'
lib/librte_power/rte_power_empty_poll.h:138: warning: Found unknown command `\policy'
lib/librte_power/rte_power_empty_poll.h:146: warning: The following parameters of rte_power_empty_poll_stat_init(struct ep_params **eptr, uint8_t *freq_tlb, struct ep_policy *policy) are not documented:
  parameter 'freq_tlb'
  parameter 'policy'