From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 2/8] ring: dynamic rss configuration Date: Mon, 13 Jul 2015 14:36:15 +0200 Message-ID: <2033219.3PlE3JM2PJ@xps13> References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-3-git-send-email-tomaszx.kulasek@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Tomasz Kulasek Return-path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id C9D5AE72 for ; Mon, 13 Jul 2015 14:37:29 +0200 (CEST) Received: by wgjx7 with SMTP id x7so294832831wgj.2 for ; Mon, 13 Jul 2015 05:37:29 -0700 (PDT) In-Reply-To: <1435589444-1988-3-git-send-email-tomaszx.kulasek@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-29 16:50, Tomasz Kulasek: > This implementation allows to set and read RSS configuration for ring > device, and is used to validate right values propagation over the slaves, > in test units for dynamic RSS configuration for bonding. > > It have no impact on packet processing by ring device. Adding some fake RSS to the ring PMD (in order to test bonding) is weird. The ring PMD is not a driver for testing. Maybe that the null PMD would be more appropriate. By the way the current RSS implementation is really bound to Intel devices. Before applying it to more drivers, we have to make sure it is generic enough. Maybe the RETA needs more abstraction.