From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] i40e: bug fix of compile error Date: Mon, 01 Dec 2014 12:12:51 +0100 Message-ID: <2036571.ijmOSAQnXA@xps13> References: <1417419227-21465-1-git-send-email-helin.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Helin Zhang Return-path: In-Reply-To: <1417419227-21465-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-01 15:33, Helin Zhang: > The compile error will occur as below when set 'RTE_LIBRTE_I40E_16BYTE_RX_DESC=y'. > The changes is just to fix it. > > lib/librte_pmd_i40e/i40e_rxtx.c: In function i40e_rxd_build_fdir: > lib/librte_pmd_i40e/i40e_rxtx.c:431:28: error: volatile union has no member named fd > lib/librte_pmd_i40e/i40e_rxtx.c:427:19: error: unused variable flexbl [-Werror=unused-variable] > lib/librte_pmd_i40e/i40e_rxtx.c:427:11: error: unused variable flexbh [-Werror=unused-variable] It would be nice to reference the commit which introduced the error and explain it a bit. > - rte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.flex_bytes_hi); > + rte_le_to_cpu_32( > + rxdp->wb.qword3.hi_dword.flex_bytes_hi); [...] > - rte_le_to_cpu_32(rxdp->wb.qword3.lo_dword.flex_bytes_lo); > + rte_le_to_cpu_32( > + rxdp->wb.qword3.lo_dword.flex_bytes_lo); Why are you wrapping these lines (with wrong indentation)? It makes the fix confuse. -- Thomas