From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] add one option memory-only for those secondary PRBs Date: Tue, 02 Dec 2014 11:01:03 +0100 Message-ID: <2039360.IUUcaknktz@xps13> References: <1417513268-6040-1-git-send-email-xiaobo.chi@nsn.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Chi, Xiaobo (NSN - CN/Hangzhou)" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, 2014-12-02 09:55, Chi, Xiaobo: > Problem: > Here, these DPDK based SECONDARY processes need only the DPDK's hugepage > based sharememory mechanism and it's upper libs (such as ring, mempool, > etc.), they need not cpu core pinning, iopl privilege changing , pci device, > timer, alarm, interrupt, shared_driver_list, core_info, threads for each > core, etc. Then, for such kind of SECONDARY processes, the current > rte_eal_init() is too heavy. > I have seen some others also met similar troubles. > > Solution: > One new EAL initializing argument, --memory-only, is added. It is only for > those SECONDARY processes which only want to share memory with primary > process. When this argument is defined, users need not define those > madentory arguments, such as "-c xx -n xx", due to we don't want to pin such > kind of processes to any CPUs. That's exactly the type of things that you should put in the commit log. It misses also a Signed-off-by. All guidelines are explained in this page: http://dpdk.org/dev#send Please check your patch with checkpatch for indentation and other details. -- Thomas