From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH RFC] usertools: add dpdk run script
Date: Fri, 14 Jul 2017 19:14:37 +0200
Message-ID: <2044129.mseWKSvA0o@xps>
References: <20170706213703.69808-1-keith.wiles@intel.com>
 <4333988E-6D77-4DB1-B37A-1FD508EEB34F@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Wiles, Keith" <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 71AC6559A
 for <dev@dpdk.org>; Fri, 14 Jul 2017 19:14:40 +0200 (CEST)
In-Reply-To: <4333988E-6D77-4DB1-B37A-1FD508EEB34F@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/07/2017 18:19, Wiles, Keith:
> > On Jul 6, 2017, at 4:37 PM, Keith Wiles <keith.wiles@intel.com> wrote:
> > 
> > I use a script like this one with pktgen and wanted to see if DPDK
> > would be interested in this application.
> > 
> > The following script adds support for executing applications using
> > a configuration file. The configuration file is formatted as a
> > python data file to be loaded by the run.py script.
> > 
> > Inside the configuration 'default.cfg' is the command line arguments
> > needed to execute the application. Any number of configuration  files
> > are allows for a single application for different execution. Normally
> > the configuration file can be in the application or example directory
> > or placed in a RTE_SDK/cfg directory.
> > 
> > The configuration file contains information about setup of the system
> > and how to run the application. The run.py script can setup the system
> > and/or execute the application with a simple command.
> > 
> > ./run.py -s default # for setup
> > ./run.py default # to execute the application.
> > 
> > I am not a great Python coder and any suggestions/patches would be great.
> 
> No comments on this RFC, should I submit a normal patch?

I have not reviewed the script.
I have just a comment about the scope of the project, as usual ;)
I am a bit worried about adding some application facilities
which may disturb library development focus of the project.

An open discussion would be useful on this topic,
so opinions (or +1/-1) are welcome!