From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 1/2] lpm: extend ip4 next_hop and add
	config structure
Date: Wed, 02 Mar 2016 16:28:57 +0100
Message-ID: <2044358.OMRF2VQKlE@xps13>
References: <1454069573-12059-1-git-send-email-michalx.kobylinski@intel.com>
 <1454069573-12059-2-git-send-email-michalx.kobylinski@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Michal Kobylinski <michalx.kobylinski@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 6BEF2376D
 for <dev@dpdk.org>; Wed,  2 Mar 2016 16:30:32 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id p65so82986457wmp.0
 for <dev@dpdk.org>; Wed, 02 Mar 2016 07:30:32 -0800 (PST)
In-Reply-To: <1454069573-12059-2-git-send-email-michalx.kobylinski@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

As suggested by Bruce, I'm looking to apply this patchset before the ARM one.
Please check the comments below.

Is it possible to split the changes in next_hop and config structure?

> --- a/doc/guides/rel_notes/release_2_3.rst
> +++ b/doc/guides/rel_notes/release_2_3.rst
> @@ -18,7 +18,11 @@ Drivers
>  
>  Libraries
>  ~~~~~~~~~
> +** librte_lpm: Increase number of next hops for IPv4 to 2^24 **
>  
> +Extend next_hop field from 8-bits to 24-bits for IPv4. Changed structures:
> +rte_lpm_tbl24_entry and rte_lpm_tbl8_entry to one structure rte_lpm_tbl_entry.
> +Added a new rte_lpm_config structure.

The spacing is wrong here. Please check also the past tense.
There is a template in the release notes.

> +BIND_DEFAULT_SYMBOL(rte_lpm_add, _v23, 2.3);
> +MAP_STATIC_SYMBOL(
> +		int rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
> +				uint32_t next_hop), rte_lpm_add_v23);

The version will be 16.04 instead of 2.3.