From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B89CC433E0 for ; Thu, 25 Feb 2021 11:41:25 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 3DF4F64F14 for ; Thu, 25 Feb 2021 11:41:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DF4F64F14 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B27E406B4; Thu, 25 Feb 2021 12:41:23 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id D05A840692 for ; Thu, 25 Feb 2021 12:41:21 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 0BAB75C0089; Thu, 25 Feb 2021 06:41:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 25 Feb 2021 06:41:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= QyfAVAVuAhw2bDPgIgz6B/vdlzlUwy7IfnsMScZk+QY=; b=2iNjGi2tIWwjWA/Z QScwqzNNXHGpOTVPQUBMZheeaAQBjAPGNh4t8ZQ8CR8hwbFEKxanoBKKs5yyvGUQ lyLKDF8WwWtT/ZEB6pJMuhl0aUgGVnNZizvci7A6zPgMWr1bcqWK8VzLxK1eGmOt RpXSSGsmJODy3M0aSbgrvs/uXJRaaukZOTZrC/8zLqyMopoqg59Z0V3kpzRopE+I LRX2UCVciypXexFAJ38Nt6CxlAOHNsIGucHXySIfOTD3yK1Td2u3aKAGF2Iig+t4 u7o/Cxn4rBMUELGCgiMK3mecRMnRrBbcBiRPUs0ft8VzltLmqULoFtUl/x0I49V/ qYGT1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=QyfAVAVuAhw2bDPgIgz6B/vdlzlUwy7IfnsMScZk+ QY=; b=bGYoa1/R79TaU7isGwRV+FDpLFJs1gIPN4NRVfHGb0Zl3Ke1ztQQCJWoJ J66Na7iul0S6ag3u9LXtwntU4kIqSzoSkyEq7TmjNABq0nz7eAJWEyxeCnjAyY7Z vlNjjyQF371BYXhCMvMPYidKq3r2UvoYuO7+JclpTfi86v/BBCh83W2QzOEPyUmY BJcNJWmDehtBo+zqjwfyFFJ29iq7OKzg2fqkE1eP28Egr3wtRh9KGOvGKyHSBiG8 NUT8Bd1y755jycXQ7Snaf141oSeKkuoc0BovGRPN9kYmvBWShJ7rt7HAJLQ41nnP 9f9hnp/szScWsHW3I0CJX/UOLx/NA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeelgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DAEE11080063; Thu, 25 Feb 2021 06:41:18 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, ferruh.yigit@intel.com, bruce.richardson@intel.com Date: Thu, 25 Feb 2021 12:41:16 +0100 Message-ID: <2047120.oh6f1MFQjV@thomas> In-Reply-To: <20210225111457.32540-1-david.marchand@redhat.com> References: <20210225111457.32540-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/02/2021 12:14, David Marchand: > Add a check on versioned symbol duplicates in map files. > > Signed-off-by: David Marchand > --- > This check could be added to buildtools/check-symbols.sh so that > regular developers catch the issue when building their changes... > Opinions? In general I am against adding developer tools in the build process, because it could cause more issues for normal users.