From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mk: fix build of assembly files for ARM64
Date: Tue, 17 Jan 2017 23:45:57 +0100
Message-ID: <2047286.uqzdbYr9PH@xps13>
References: <1484663736-32195-1-git-send-email-zbigniew.bodek@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
 konstantin.ananyev@intel.com
To: zbigniew.bodek@caviumnetworks.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 4AC69DE5
 for <dev@dpdk.org>; Tue, 17 Jan 2017 23:45:58 +0100 (CET)
Received: by mail-wm0-f53.google.com with SMTP id c85so220996150wmi.1
 for <dev@dpdk.org>; Tue, 17 Jan 2017 14:45:58 -0800 (PST)
In-Reply-To: <1484663736-32195-1-git-send-email-zbigniew.bodek@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-17 15:35, zbigniew.bodek@caviumnetworks.com:
> -# for now, we don't use as but nasm.
> -# AS      = $(CROSS)as

It looks to be a very very old comment.

> +ifeq ($(CONFIG_RTE_ARCH_X86),y)
>  AS        = nasm

There is no asm file in DPDK as far as I know.
So why would we have a dependency on nasm for x86?

> +else
> +AS        = $(CROSS)as
> +endif