From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] test-meson-builds: add 32-bit compilation test Date: Mon, 17 Sep 2018 15:38:58 +0200 Message-ID: <2047675.hNTm73f6kF@xps> References: <20180829160252.7890-1-bruce.richardson@intel.com> <4200777.W2uOughg41@xps> <20180917125402.GA3464@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id F222725D9 for ; Mon, 17 Sep 2018 15:39:01 +0200 (CEST) In-Reply-To: <20180917125402.GA3464@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/09/2018 14:54, Bruce Richardson: > On Mon, Sep 17, 2018 at 02:03:50PM +0200, Thomas Monjalon wrote: > > 29/08/2018 18:02, Bruce Richardson: > > > Add in a cross-file to enable 32-bit compile tests as part > > > of the test-meson-builds script. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > NOTE: For ease of use, it's recommended that meson 0.47 be used for > > > this testing. With earlier versions, it may be necessary to ensure that > > > the same development packages are installed for both 64-bit and 32-bit. > > > --- > > > config/x86/i686_sse4_linuxapp_gcc | 18 ++++++++++++++++++ > > > devtools/test-meson-builds.sh | 4 ++++ > > > 2 files changed, 22 insertions(+) > > > > I'm not sure about adding this test as mandatory, because 32-bit version > > of libraries can be hard to get, especially libbsd and libnuma. > > I hope this test will be run by all developers, so we should not discourage > > them by adding too many requirements. > > Opinion? Idea? > > Libbsd is not required, but yes, libnuma is, so you do need a 32-bit > libnuma (devel) installed to run this test. I would expect that to be > available on most distros though. I'm open to suggestions as to how to make > this optional, but I do think that sanity checking 32-bit is good practice > to avoid errors, e.g. those wonderful printf format strings for uint64_t.* I agree and I am testing i686 with the "make build system". I define DPDK_DEP_NUMA=n which disables any NUMA option. Can we have this kind of tweak with meson? Or perhaps we can just have an option in the script to disable this test?