From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: Issue with rte_compat versioning macros Date: Fri, 19 Jun 2015 07:48:02 -0700 (PDT) Message-ID: <2048288.aStCxb75UN@xps13> References: <9CC680510C0AC140A846FED2EF7F96281383E81B@IRSMSX102.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Gajdzica, MaciejX T" Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 10672C840 for ; Fri, 19 Jun 2015 16:48:03 +0200 (CEST) Received: by wicgi11 with SMTP id gi11so20936972wic.0 for ; Fri, 19 Jun 2015 07:48:02 -0700 (PDT) In-Reply-To: <9CC680510C0AC140A846FED2EF7F96281383E81B@IRSMSX102.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-19 14:38, Gajdzica, MaciejX T: > There is an issue with macros in rte_compat.h. For shared library case, macro BIND_DEFAULT_SYMBOL > takes three arguments and for other case it takes only two arguments. Also letters for macro variable names > are not consistent in these two cases. Yes, and your patch fix it: http://dpdk.org/dev/patchwork/patch/5475/ But it is part of a series which is not accepted yet. It would be faster merged if you send it as a standalone patch. Thanks