From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] tools: add tags and cscope index file generation support Date: Thu, 12 Jan 2017 14:19:44 +0000 Message-ID: <204efa1f-0631-ed9c-3d68-8c573edfbb76@intel.com> References: <1480205562-32745-1-git-send-email-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: thomas.monjalon@6wind.com To: Jerin Jacob , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 07DBE69FC for ; Thu, 12 Jan 2017 15:19:46 +0100 (CET) In-Reply-To: <1480205562-32745-1-git-send-email-jerin.jacob@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/27/2016 12:12 AM, Jerin Jacob wrote: > This script generates cscope, gtags, and tags > index files based on EAL environment. > (architecture and OS(linux/bsd)) > > Selection of the architecture and OS environment > is based on dpdk configuration target(T=) > > example usage: > make tags T=x86_64-native-linuxapp-gcc > make cscope T=x86_64-native-linuxapp-gcc > make gtags T=x86_64-native-linuxapp-gcc > > Signed-off-by: Jerin Jacob <...> > + > +if [ -n "$T" ]; then <...> > + usage $1 > + exit I would prefer fallback to RTE_TARGET parsing, or processing all files ( cscope -Rqn ), instead of exiting here, but that is your call. Also "tags.sh" needs to be moved into "devtools" after latest updates. Reviewed-by: Ferruh Yigit