From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] vfio: fix pci_vfio_map_resource
Date: Fri, 15 Jul 2016 18:56:24 +0200
Message-ID: <2054704.Nkh3RPcrvj@xps13>
References: <20160714153415.GA8329@gmail.com> <6504660.SWBHcg24lf@xps13>
 <2113476.6KVZGvHTNJ@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, anatoly.burakov@intel.com, dan@kernelim.com,
 Ronghua Zhang <rzhang@vmware.com>
To: Yong Wang <yongwang@vmware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id CA04A4AC7
 for <dev@dpdk.org>; Fri, 15 Jul 2016 18:56:25 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id o80so38001631wme.1
 for <dev@dpdk.org>; Fri, 15 Jul 2016 09:56:25 -0700 (PDT)
In-Reply-To: <2113476.6KVZGvHTNJ@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-15 18:42, Thomas Monjalon:
> 2016-07-15 17:32, Thomas Monjalon:
> > 2016-07-14 17:15, Yong Wang:
> > > -=09=09=09=09void *second_addr =3D RTE_PTR_ADD(bar_addr, memreg[1=
].offset);
> > > +=09=09=09=09void *second_addr =3D RTE_PTR_ADD(bar_addr,
> > > +=09=09=09=09=09=09=09=09memreg[1].offset - reg.offset);
> >=20
> > There is an error for 32-bit:
> > =09error: cast to pointer from integer of different size
> > =09note: in expansion of macro =E2=80=98RTE_PTR_ADD=E2=80=99
>=20
> It can fixed like this:
> -                    memreg[1].offset - reg.offset);
> +                    memreg[1].offset -
> +                    (uintptr_t)reg.offset);
>=20

Applied with above change, thanks