From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066D6C2BA19 for ; Mon, 6 Apr 2020 13:30:07 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8D64D206F8 for ; Mon, 6 Apr 2020 13:30:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="S83TsOKo"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RpKjCheR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D64D206F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C86E22BE2; Mon, 6 Apr 2020 15:30:05 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 970E02B96 for ; Mon, 6 Apr 2020 15:30:04 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id B2011580094; Mon, 6 Apr 2020 09:30:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 06 Apr 2020 09:30:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1ygzfcaup7nuar4BeAJMWyz+xq8v9t7CqQY3ofRj9yg=; b=S83TsOKoJQTL bDG+qxyiDQT4nZ+2d+pKmQieE+rBEXTdCfx4c8K4aMCW6al9jmDS7Q49n3I2Is+h KTL4PRa/ulVPPZnvn7h8hIQI0xBz+8LBtt13T9A36m1Ya4btKyVFi/0LgZD9rSxr VQnbYh3HZbAXq4Enjy8BJHl1eF8zCS0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1ygzfcaup7nuar4BeAJMWyz+xq8v9t7CqQY3ofRj9 yg=; b=RpKjCheRCmjI4VAMK5sHBhrEDC12VJndU+fGU4SAXy3tufc+xcSsJlIJ0 +h/Sq8Y1594yBH4/pAH/cqh45TlFVFbvvaOJ/mLhf9GaDQhy6tB/SfRvzA3vOMV/ vTu17XnbYbnfgrXcgYWvyy1yYaIjSmmzm4brRf8+TcT67pye5XY9E1FULJxDG/kx vvGqjieMwrB9zuy6UiufBXSStD8Ra6S2IgmDPYGWj/UCU7gg2sxyjvYGCMD+VRC4 cDQO/yp3AlHouM0CJ7KeIx0TPFdj8lMDHvldJr4PEurBsEJ1QWXhx+3d0Kk/W+O1 Bxz7EWUU9yJGMhxSckeaVzrWwqOHg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefgdehlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0ACFB306D420; Mon, 6 Apr 2020 09:29:53 -0400 (EDT) From: Thomas Monjalon To: Ori Kam , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , Pavan Nikhilesh Bhagavatula Cc: "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Parav Pandit Date: Mon, 06 Apr 2020 15:29:52 +0200 Message-ID: <2061995.157zFVKu8G@xps> In-Reply-To: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > From: Pavan Nikhilesh Bhagavatula > >> >> From: Pavan Nikhilesh Bhagavatula > >> >> > >> >> Looks like this implementation is incomplete? > >> >> I don't see any pmd specific helper functions for @see > >> >rte_cryptodev_pmd.c, > >> >> rte_eventdev_pmd* > >> >> > >> >I think the current implementation includes all needed functions, > >> >at least for the first stage. > >> >You can find in rte_regexdev_driver.h the functions that should be > >> >called > >> >by the PMD. We have the register / unregister which acts the same > >as > >> >create > >> >and destroy. For parsing argument the PMD may call > >rte_kvargs_parse. > >> > > >> > >> _driver.h should atleast include > >> rte_regex_dev_pci_generic_probe/rte_regex_pmd_vdev_init > >> else there would be a lot of code repetition and possibly udefined > >behavior > >> at the driver layer. > >> > >Why should they be included? At least in this stage, there is no code to > >share > >ethdev why should we add code for the vdev? > > Ok I think I failed to communicate my concerns across. > Let me retry > > 1. SW based regex devices such as PCRE/Hyperscan rely on vdev framework > i.e. user needs to pass an EAL argument --vdev="regex_pcre" for the driver to > initialize all the other EAL subsystems (ethdev, eventdev, cryptodev, etc..)support this. vdev helpers do not have to be part of the first patches which define API. It should be added when adding the first vdev driver. > 2. HW based independent regex devices that are exposed as PCI devices would need > pci probe helpers. Same, PCI helpers can be added while adding the first PCI driver. We can synchronize about how to split the work, avoiding two developers doing the same thing. But let's not mandate this work to be done as part of this first series.