From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] eal: fix build for bsd
Date: Wed, 02 Jul 2014 12:05:08 +0200
Message-ID: <2062090.RJjRv0m9u1@xps13>
References: <AA3F441F262C58498CD6D0C1801DE7EB0AABC6D0@SHSMSX103.ccr.corp.intel.com>
 <1404292944-5964-1-git-send-email-thomas.monjalon@6wind.com>
 <6D0EE020084B194084D70B0A8D2207B8E8EA6B@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Zhan, Zhaochen" <zhaochen.zhan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <6D0EE020084B194084D70B0A8D2207B8E8EA6B-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Zhaochen,

Please read answer below:

2014-07-02 09:58, Zhan, Zhaochen:
> I have tested the patch, it still has a build error although it is different
> from the previous one.
> 
> OS: FreeBSD10
> 
> == Build lib/librte_pmd_bond
>   CC rte_eth_bond_api.o
> /root/zzc/dpdk-1.7.0-rc3/lib/librte_pmd_bond/rte_eth_bond_api.c:35:27: fatal
> error: linux/binfmts.h: No such file or directory #include
> <linux/binfmts.h>

Please check with the latest version in master branch (after rc3).
It should be fixed by Helin's patch of today.

Thanks
-- 
Thomas


> > -----Original Message-----
> > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Thomas Monjalon
> > Sent: Wednesday, July 02, 2014 5:22 PM
> > To: dev-VfR2kkLFssw@public.gmane.org
> > Subject: [dpdk-dev] [PATCH] eal: fix build for bsd
> > 
> > When adding link bonding to EAL initialization (a155d430119),
> > an include was missing for BSD.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> > ---
> > 
> >  lib/librte_eal/bsdapp/eal/eal.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > Please, a quick test and acknowledgement of this fix would be helpful.
> > 
> > 
> > diff --git a/lib/librte_eal/bsdapp/eal/eal.c
> > b/lib/librte_eal/bsdapp/eal/eal.c index ec57b26..69ead31 100644
> > --- a/lib/librte_eal/bsdapp/eal/eal.c
> > +++ b/lib/librte_eal/bsdapp/eal/eal.c
> > @@ -66,6 +66,7 @@
> > 
> >  #include <rte_cpuflags.h>
> >  #include <rte_interrupts.h>
> >  #include <rte_pci.h>
> > 
> > +#include <rte_dev.h>
> > 
> >  #include <rte_devargs.h>
> >  #include <rte_common.h>
> >  #include <rte_version.h>
> > 
> > --
> > 2.0.0