From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] compat: merge compat library into EAL Date: Mon, 25 Feb 2019 15:59:57 +0100 Message-ID: <2063813.xZsQsPevWC@xps> References: <20190110111104.56464-1-bruce.richardson@intel.com> <20190206110130.55135-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, stable@dpdk.org, Neil Horman , David Marchand , Anatoly Burakov To: Bruce Richardson Return-path: In-Reply-To: <20190206110130.55135-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/02/2019 12:01, Bruce Richardson: > Since compat library is only a single header, we can easily move it into > the EAL common headers instead of tracking it separately. The downside of > this is that it becomes a little more difficult to have any libs that are > built before EAL depend on it. Thankfully, this is not a major problem as > the only library which uses rte_compat.h and is built before EAL (kvargs) > already has the path to the compat.h header file explicitly called out as > an include path. > > However, to ensure that we don't hit problems later with this, we can add > EAL common headers folder to the global include list in the meson build > which means that all common headers can be safely used by all libraries, no > matter what their build order. > > As a side-effect, this patch also fixes an issue with building on BSD using > meson, due to compat lib no longer needing to be listed as a dependency. > > Fixes: a8499f65a1d1 ("log: add missing experimental tag") > > CC: stable@dpdk.org > CC: Neil Horman > Signed-off-by: Bruce Richardson > Reviewed-by: David Marchand > Tested-by: David Marchand > Tested-by: Anatoly Burakov Applied, thanks