From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] ethdev: keep port_id unchanged if obtaining
	by name failed
Date: Fri, 09 Jun 2017 18:34:44 +0200
Message-ID: <2063900.e1OC17koPI@xps>
References: <CGME20170518121955eucas1p211ce46317d0d74c99db0b94c1662fb59@eucas1p2.samsung.com>
 <1495109980-3236-1-git-send-email-i.maximets@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Heetae Ahn <heetae82.ahn@samsung.com>,
 Ravi Kerur <rkerur@gmail.com>
To: Ilya Maximets <i.maximets@samsung.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BBDE6397D
 for <dev@dpdk.org>; Fri,  9 Jun 2017 18:34:45 +0200 (CEST)
In-Reply-To: <1495109980-3236-1-git-send-email-i.maximets@samsung.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

18/05/2017 14:19, Ilya Maximets:
> Currently, 'rte_eth_dev_get_port_by_name' changes transmitted
> 'port_id' unconditionally. This is undocumented and misleading
> behaviour as user may expect unchanged value in case of error.
> 
> Otherwise, there is no sense having both return value and
> a pointer in the function.
> 
> Fixes: 9c5b8d8b9feb ("ethdev: clean port id retrieval when attaching")
> 
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>

Applied, thanks