From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 0/8] L2fwd-crypto fixes/enhancements
Date: Thu, 31 Mar 2016 14:19:55 +0200
Message-ID: <2064315.gYR8cJ1A1U@xps13>
References: <1459414919-44829-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1459416734-54479-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <20160331121417.GA27312@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 declan.doherty@intel.com
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id E7E976CA1
 for <dev@dpdk.org>; Thu, 31 Mar 2016 14:21:48 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id p65so222676550wmp.1
 for <dev@dpdk.org>; Thu, 31 Mar 2016 05:21:48 -0700 (PDT)
In-Reply-To: <20160331121417.GA27312@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-31 13:14, Bruce Richardson:
> On Thu, Mar 31, 2016 at 10:32:06AM +0100, Pablo de Lara wrote:
> > This patches fixes some small issues in L2fwd-crypto
> > app and also improves the app, making it more flexible
> > (accepting different key sizes)
> > and readable (information display improvement).
> > 
> > Series-tested-by: Min Cao <min.cao@intel.com>
> > 
> 
> Hi,
> 
> Just some general advice:
> 
> When someone is acking/resporting a tested-by for a patch series it's ok to 
> reply to the patch 0.
> 
> However, for subsequent versions of the patchset itself, the acks and tested-bys
> should be placed on (all) the patches themselves, not in the cover letter. If
> it's in the cover letter, you're forcing the applier of the patch to modify each
> one individually to stick on the extra information.

Yes
More information about Tested-by:
In general it doesn't apply to each patch. Example, here, I doubt
it has to be added to the patch "add missing new line character in help".

Thanks for adding the tag where relevant (by reading the test report).

[...]
> > Pablo de Lara (8):
> >   l2fwd-crypto: add missing new line character in help
> >   l2fwd-crypto: rename period parameter
> >   l2fwd-crypto: add missing string initialization
> >   l2fwd-crypto: fix length of random IV/AAD
> >   l2fwd-crypto: fix ambiguous input key size
> >   l2fwd-crypto: clarify key parsing in help
> >   l2fwd-crypto: use key-value list of supported algorithms
> >   l2fwd-crypto: extend crypto information