From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 3/3] eal: remove rte_pci_dev_ids.h
Date: Sat, 06 Aug 2016 14:55:57 +0200
Message-ID: <2065608.RmlMMznbWI@xps13>
References: <1470406171-24754-1-git-send-email-ferruh.yigit@intel.com>
 <1470406171-24754-4-git-send-email-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
 Helin Zhang <helin.zhang@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id A5E0258D6
 for <dev@dpdk.org>; Sat,  6 Aug 2016 15:04:42 +0200 (CEST)
Received: by mail-wm0-f53.google.com with SMTP id i5so71028909wmg.0
 for <dev@dpdk.org>; Sat, 06 Aug 2016 06:04:42 -0700 (PDT)
In-Reply-To: <1470406171-24754-4-git-send-email-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-08-05 15:09, Ferruh Yigit:
> All PCI device ids moved to drivers, it is safe to delete
> rte_pci_dev_ids.h

Good move. Thanks Ferruh!

> --- a/doc/guides/prog_guide/dev_kit_build_system.rst
> +++ b/doc/guides/prog_guide/dev_kit_build_system.rst
> @@ -93,20 +93,20 @@ Each build directory contains include files, libraries, and applications:
>      cmdline_cirbuf.h           rte_cycles.h         rte_memory.h
>      cmdline.h                  rte_debug.h          rte_mempool.h
>      cmdline_parse_etheraddr.h  rte_eal.h            rte_memzone.h
> -    cmdline_parse.h            rte_errno.h          rte_pci_dev_ids.h
> -    cmdline_parse_ipaddr.h     rte_ethdev.h         rte_pci.h
> -    cmdline_parse_num.h        rte_ether.h          rte_per_lcore.h
> -    cmdline_parse_portlist.h   rte_fbk_hash.h       rte_prefetch.h
> -    cmdline_parse_string.h     rte_hash_crc.h       rte_random.h
> -    cmdline_rdline.h           rte_hash.h           rte_ring.h
> -    cmdline_socket.h           rte_interrupts.h     rte_rwlock.h
> -    cmdline_vt100.h            rte_ip.h             rte_sctp.h
> -    exec-env                   rte_jhash.h          rte_spinlock.h
> -    rte_alarm.h                rte_launch.h         rte_string_fns.h
> -    rte_atomic.h               rte_lcore.h          rte_tailq.h
> -    rte_branch_prediction.h    rte_log.h            rte_tcp.h
> -    rte_byteorder.h            rte_lpm.h            rte_timer.h
> -    rte_common.h               rte_malloc.h         rte_udp.h
> +    cmdline_parse.h            rte_errno.h          rte_pci.h
> +    cmdline_parse_ipaddr.h     rte_ethdev.h         rte_per_lcore.h
> +    cmdline_parse_num.h        rte_ether.h          rte_prefetch.h
> +    cmdline_parse_portlist.h   rte_fbk_hash.h       rte_random.h
> +    cmdline_parse_string.h     rte_hash_crc.h       rte_ring.h
> +    cmdline_rdline.h           rte_hash.h           rte_rwlock.h
> +    cmdline_socket.h           rte_interrupts.h     rte_sctp.h
> +    cmdline_vt100.h            rte_ip.h             rte_spinlock.h
> +    exec-env                   rte_jhash.h          rte_string_fns.h
> +    rte_alarm.h                rte_launch.h         rte_tailq.h
> +    rte_atomic.h               rte_lcore.h          rte_tcp.h
> +    rte_branch_prediction.h    rte_log.h            rte_timer.h
> +    rte_byteorder.h            rte_lpm.h            rte_udp.h
> +    rte_common.h               rte_malloc.h
>      rte_config.h               rte_mbuf.h

What do you think about this list? I would say we can remove it.