From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/2] L3FWD sample optimisation Date: Wed, 11 Jun 2014 00:44:51 +0200 Message-ID: <2066022.Iqp5aeoHOS@xps13> References: <2601191342CEEE43887BDE71AB9772580EFB3529@IRSMSX105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Ananyev, Konstantin" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFB3529-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Konstantin, 2014-05-28 09:17, Ananyev, Konstantin: > Hi Thomas, > > >As you are doing optimizations, it's important to know the performance gain. > >It could help to mitigate future reworks. > >So please, could you provide some benchmarking numbers in the commit log? > > Some performance data below. > Also, forgot to mention that new code path can be switched on/off by setting > ENABLE_MULTI_BUFFER_OPTIMIZE macro to 1/0. > Do I need to resubmit the whole patch series, or just a cover letter, or ...? I think you should resubmit the whole serie after having checked it with checkpatch.pl. Please keep Acked-by and Tested-by lines from previous mails. Thanks -- Thomas