From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] kni: fix build on Centos 7.4 when Ethtool
	enabled
Date: Tue, 22 May 2018 22:13:29 +0200
Message-ID: <2066106.EVIWKkP5ao@xps>
References: <20180522181008.6327-1-dg@adax.com>
 <ec9f0e98-cb78-3e28-75d9-d15edc9c4e4f@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
To: Dan Gora <dg@adax.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 295F92629
 for <dev@dpdk.org>; Tue, 22 May 2018 22:13:31 +0200 (CEST)
In-Reply-To: <ec9f0e98-cb78-3e28-75d9-d15edc9c4e4f@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/05/2018 20:50, Ferruh Yigit:
> On 5/22/2018 7:10 PM, Dan Gora wrote:
> > Fix compilation errors on Centos 7.4 when CONFIG_RTE_KNI_KMOD_ETHTOOL
> > is set to 'y'.
> >=20
> > Centos 7.4 needs HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL:
> >=20
> > igb_main.c: In function =E2=80=98igb_ndo_bridge_getlink=E2=80=99:
> > igb_main.c:2289:2: error: too few arguments to function
> >                    =E2=80=98ndo_dflt_bridge_getlink=E2=80=99
> >   return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode, 0, 0, nlflag=
s);
> >   ^
> >=20
> > Centos 7.4 needs HAVE_VF_VLAN_PROTO and needs to redefine
> > ndo_set_vf_vlan to .extended.ndo_set_vf_vlan:
> >=20
> > igb_main.c:2318:2: error: unknown field =E2=80=98ndo_set_vf_vlan=E2=80=
=99 specified
> >                    in initializer
> >   .ndo_set_vf_vlan =3D igb_ndo_set_vf_vlan,
> >   ^
> >=20
> > Signed-off-by: Dan Gora <dg@adax.com>
>=20
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks