From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/2] mbuf: remove deprecated macro
Date: Mon, 14 Jan 2019 10:50:50 +0100
Message-ID: <2069315.XgEaZRbMEa@xps>
References: <20190114052055.12896-1-yskoh@mellanox.com>
 <210872a4-5e85-bef3-dca1-2e468be373bb@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: konstantin.ananyev@intel.com, olivier.matz@6wind.com, dev@dpdk.org
To: Andrew Rybchenko <arybchenko@solarflare.com>,
 Yongseok Koh <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3A4891B192
 for <dev@dpdk.org>; Mon, 14 Jan 2019 10:50:53 +0100 (CET)
In-Reply-To: <210872a4-5e85-bef3-dca1-2e468be373bb@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/01/2019 08:40, Andrew Rybchenko:
> On 1/14/19 8:20 AM, Yongseok Koh wrote:
> > RTE_MBUF_INDIRECT() is replaced with RTE_MBUF_CLONED() and removed.
> > This macro was deprecated in release 18.05 when EXT_ATTACHED_MBUF was
> > introduced.
> >
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> <...>
> 
> > diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19_02.rst
> > index 5a46f1acdc..c4ad072412 100644
> > --- a/doc/guides/rel_notes/release_19_02.rst
> > +++ b/doc/guides/rel_notes/release_19_02.rst
> > @@ -210,6 +210,9 @@ API Changes
> >     function from now on. Failed to do so will cause
> >     ``rte_cryptodev_sym_session_create()`` function call return error.
> >   
> > +* mbuf: ``RTE_MBUF_INDIRECT()``, which was deprecated in 18.05, was replaced
> > +  with ``RTE_MBUF_CLONED()`` and removed in 19.02.
> > +
> 
> May be order in New Features should be applicable in API changes as well.

Yes
Usually I take care of it when applying, but would be better to be fixed
in the patch itself :)