From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 3/3] vfio: use the generic multi-process channel Date: Thu, 25 Jan 2018 11:57:06 +0100 Message-ID: <2069506.YIxbetVmv7@xps> References: <1512067450-59203-1-git-send-email-jianfeng.tan@intel.com> <2010166.0Q39LqRaO8@xps> <3fe4f70a-eeb6-e061-5d2e-8b62578ced47@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Jianfeng Tan , dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com To: "Burakov, Anatoly" Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 92FAC1E35 for ; Thu, 25 Jan 2018 11:57:48 +0100 (CET) In-Reply-To: <3fe4f70a-eeb6-e061-5d2e-8b62578ced47@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/01/2018 11:52, Burakov, Anatoly: > On 25-Jan-18 10:47 AM, Thomas Monjalon wrote: > > 25/01/2018 05:16, Jianfeng Tan: > >> Previously, vfio uses its own private channel for the secondary > >> process to get container fd and group fd from the primary process. > >> > >> This patch changes to use the generic mp channel. > > > > There was a private request to get it in 18.02-rc2. > > > > I have 3 concerns: > > 1/ It is late > > 2/ It is not yet reviewed by Anatoly and Konstantin > > 3/ We try to not rework the existing code in RC2, > > because it would totally invalidate the validation work > > done for RC1. > > > > > > Hi Thomas, > > We can postpone the VFIO patch until 18.05, and integrate only the first > two patches. First two patches do not change anything in DPDK, so > validation impact should be non-existent. Yes, possible if it is well reviewed and all comments addressed.