From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] vfio: noiommu check error handling Date: Sat, 13 Jan 2018 23:49:30 +0100 Message-ID: <2075027.JcYejM7RvO@xps> References: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com> <5559040.Nhk1psZjz2@xps> <45d1aa7c-2ceb-b6df-8e16-83ff1316cba1@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Burakov, Anatoly" , Jonas Pfefferle1 Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 28904A490 for ; Sat, 13 Jan 2018 23:50:02 +0100 (CET) In-Reply-To: <45d1aa7c-2ceb-b6df-8e16-83ff1316cba1@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/01/2018 13:15, Burakov, Anatoly: > On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: > > 07/11/2017 10:50, Jonas Pfefferle1: > >>> Is there something urgent for 17.11? > >>> Or can it be refined in 18.02? > >> > >> Nothing urgent. We can refine this for 18.02. > >> > >>> Anatoly, any thought? > > > > Anatoly, Jonas, how do you want to proceed with this patch? > > > > I don't see anything to be refined here, it's a simple bug fix - code > assumes noiommu mode support is always available, when it might not be > the case on older kernels. As a bug fix, the title must start with "fix" and a tag "Fixes:" must be added to help with backport. At the same time, the explanation of the bug must be added in the commit log please. Thanks