From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] config: build nfp pmd support by default Date: Tue, 17 Jan 2017 21:55:20 +0100 Message-ID: <2075524.r0YEMkGTG2@xps13> References: <1484308202-5198-1-git-send-email-alejandro.lucero@netronome.com> <29aed2ee-78a9-05d5-b684-01f7b62d10f9@intel.com> <20170116164816.GA25960@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Alejandro Lucero , dev@dpdk.org To: Bruce Richardson , Ferruh Yigit Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id C886B108F for ; Tue, 17 Jan 2017 21:55:22 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id r144so242368545wme.1 for ; Tue, 17 Jan 2017 12:55:22 -0800 (PST) In-Reply-To: <20170116164816.GA25960@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-16 16:48, Bruce Richardson: > On Mon, Jan 16, 2017 at 04:43:11PM +0000, Ferruh Yigit wrote: > > On 1/13/2017 11:50 AM, Alejandro Lucero wrote: > > > Because using a NFP PMD requires specific BSP installed, the PMD > > > support was not the default option before. This was just for making > > > people aware of such dependency, since there is no need for such a > > > BSP for just compiling DPDK with NFP PMD support. > > > > Although NFP will compile fine, as far as I understand BSP dependency is > > still there. > > > > Thomas, > > > > What do you think, is compilation enough to be enabled by default? > > > > > > Although you haven't asked me, I think having it compiled by default is > ok, even if you can't run it without the BSP. Having it compiled means > that we can catch errors or problems with the driver sooner, e.g. when > doing updates across all drivers. +1 (I suggested this change to Alejandro if I remember well)