From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] scripts: add git hook scripts for checkpatch
	and auto doc generation
Date: Tue, 24 Nov 2015 18:44:36 +0100
Message-ID: <2076055.LzC464LxxN@xps13>
References: <1446160974-31675-1-git-send-email-ferruh.yigit@intel.com>
 <1446817732-17873-1-git-send-email-ferruh.yigit@intel.com>
 <1446817732-17873-2-git-send-email-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id ECD2191A0
 for <dev@dpdk.org>; Tue, 24 Nov 2015 18:45:54 +0100 (CET)
Received: by wmuu63 with SMTP id u63so106925802wmu.0
 for <dev@dpdk.org>; Tue, 24 Nov 2015 09:45:54 -0800 (PST)
In-Reply-To: <1446817732-17873-2-git-send-email-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks for the idea

2015-11-06 13:48, Ferruh Yigit:
> post-merge: Same script as "post-commit", but triggered after git pull

A symbolic link would be sufficient.
As it must be installed in the git hooks (probably making a symbolic link),
duplicating the file is not needed at all.

> pre-commit: Does a checkpatch check before commit started. If script
> finds any error it will print warnings and fails. If  checkpatch
> fails commit also fails. This guaranties every commit pass checkpatch.
> Default script is <dpdk>/scripts/checkpatch.pl but this can be
> changed by RTE_CHECKPATCH environment variable. Also a default list
> of checkpatch ignore items defined, new ones can be added by IGNORE
> environment variable.

Please use the new scripts/checkpatches.sh:
http://dpdk.org/dev/patchwork/patch/9036/

> This script can bypassed by commit "--no-verify" argument.

Could you document the --no-verify option in the script?

> Deployment:
> To make scripts active they need to be in <dpdk>/.git/hooks folder.
> Alternatively "deploy.sh" script can be used, it simply copies all
> scripts into proper folder. Script names are significant and
> shouldn't changed.

Why not using symbolic links?