From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] config: remove duplicate configuration
	information
Date: Fri, 04 Mar 2016 16:26:10 +0100
Message-ID: <208181529.lrFE2OKGXu@xps13>
References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com>
 <71CD93A7-D0E2-48DC-8368-53C49504CB25@intel.com>
 <320C8D24-5875-4474-8FF9-CFC5980C9C20@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Wiles, Keith" <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 7EB192956
 for <dev@dpdk.org>; Fri,  4 Mar 2016 16:27:47 +0100 (CET)
Received: by mail-wm0-f50.google.com with SMTP id p65so24945542wmp.1
 for <dev@dpdk.org>; Fri, 04 Mar 2016 07:27:47 -0800 (PST)
In-Reply-To: <320C8D24-5875-4474-8FF9-CFC5980C9C20@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-04 14:44, Wiles, Keith:
> >>>
> >>>--- a/config/defconfig_x86_64-native-bsdapp-clang
> >>>+++ b/config/defconfig_x86_64-native-bsdapp-clang
> >>>@@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
> >>>  CONFIG_RTE_ARCH="x86_64"
> >>>  CONFIG_RTE_ARCH_X86_64=y
> >>>  CONFIG_RTE_ARCH_X86=y
> >>>+CONFIG_RTE_ARCH_64=y
> >>>  
> >>>  CONFIG_RTE_TOOLCHAIN="clang"
> >>>  CONFIG_RTE_TOOLCHAIN_CLANG=y
> >>>diff --git a/config/defconfig_x86_64-native-bsdapp-gcc b/config/defconfig_x86_64-native-bsdapp-gcc
> >>>index 5a6a4e8..4ea4433 100644
> >>>--- a/config/defconfig_x86_64-native-bsdapp-gcc
> >>>+++ b/config/defconfig_x86_64-native-bsdapp-gcc
> >>>@@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
> >>>  CONFIG_RTE_ARCH="x86_64"
> >>>  CONFIG_RTE_ARCH_X86_64=y
> >>>  CONFIG_RTE_ARCH_X86=y
> >>>+CONFIG_RTE_ARCH_64=y
> >>
> >>It should be a totally separate patch.
> >>And there are other places where it is missing.
> 
> I looked in the other defconfig_XXX files and did not see any other places that were missing the CONFIG_RTE_ARCH_64, can you point out those places.

% ls -1 config/defconfig_*64*
config/defconfig_arm64-armv8a-linuxapp-gcc
config/defconfig_arm64-thunderx-linuxapp-gcc
config/defconfig_arm64-xgene1-linuxapp-gcc
config/defconfig_ppc_64-power8-linuxapp-gcc
config/defconfig_x86_64-ivshmem-linuxapp-gcc
config/defconfig_x86_64-ivshmem-linuxapp-icc
config/defconfig_x86_64-native-bsdapp-clang
config/defconfig_x86_64-native-bsdapp-gcc
config/defconfig_x86_64-native-linuxapp-clang
config/defconfig_x86_64-native-linuxapp-gcc
config/defconfig_x86_64-native-linuxapp-icc

% git grep -l RTE_ARCH_64 config
config/defconfig_arm64-armv8a-linuxapp-gcc
config/defconfig_ppc_64-power8-linuxapp-gcc
config/defconfig_tile-tilegx-linuxapp-gcc
config/defconfig_x86_64-native-linuxapp-clang
config/defconfig_x86_64-native-linuxapp-gcc
config/defconfig_x86_64-native-linuxapp-icc

And you've patched:
config/defconfig_x86_64-native-bsdapp-clang
config/defconfig_x86_64-native-bsdapp-gcc

So the missing files seems to be
config/defconfig_arm64-thunderx-linuxapp-gcc
config/defconfig_arm64-xgene1-linuxapp-gcc
config/defconfig_x86_64-ivshmem-linuxapp-gcc
config/defconfig_x86_64-ivshmem-linuxapp-icc

But they include other defconfigs which have ARCH_64.
So you're right, there is no missing file.
Sorry for the confusion