From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/2] eal/ipc: fix use-after-free in synchronous requests Date: Tue, 17 Apr 2018 01:19:35 +0200 Message-ID: <2082606.hxpljrm1bS@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Tan, Jianfeng" To: Anatoly Burakov Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0D072EE2D for ; Tue, 17 Apr 2018 01:19:38 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/04/2018 17:33, Tan, Jianfeng: > > On 4/13/2018 7:54 PM, Anatoly Burakov wrote: > > Previously, we were adding synchronous requests to request list, we > > were doing it after checking if request existed. However, we only > > removed the request from the request list if we have succeeded in > > sending the request. In case of failed request send, we left an > > invalid pointer in the request list. > > > > Fix this by only adding request to the list once we succeed in > > sending it. > > > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") > > Cc: jianfeng.tan@intel.com > > > > Signed-off-by: Anatoly Burakov > > Nice catch. > > Acked-by: Jianfeng Tan Series applied, thanks